Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2931423002: Prepare for improved error recovery from compile-time errors. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, vm-dev_dartlang.org, Lasse Reichstein Nielsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prepare for improved error recovery from compile-time errors. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/14e9d0bd89b995ab92a78627aa0dca082ba83b50

Patch Set 1 #

Patch Set 2 : Rebased on ea30fb6a0d11fa79d5e312a62fae2c3f31e7aee4. #

Patch Set 3 : Rebased on 11f82b12d2fb4f2c323cbc5a25de9835cc8e5031 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -13 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 2 chunks +16 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/kernel/lib/core_types.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M runtime/lib/errors_patch.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/core/errors.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 6 months ago (2017-06-12 14:49:03 UTC) #2
Paul Berry
lgtm
3 years, 6 months ago (2017-06-13 13:54:37 UTC) #3
ahe
3 years, 6 months ago (2017-06-13 13:59:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
14e9d0bd89b995ab92a78627aa0dca082ba83b50 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698