Remove references to groups directly stored on ComputedStyle in .cpp file

Remove references to groups directly stored on ComputedStyle in .cpp file

This patch ensures that there are no references to the following groups
in ComputedStyle.cpp:
1. BoxData
2. BackgroundData
3. VisualData
4. SurroundData
5. InheritedData
6. RareInheritedData

RareNonInheritedData is left to a separate CL

Diff: https://gist.github.com/nainar/0052646dd5dbb1b50af360551122b442/revisions

BUG=710938
Review-Url: https://codereview.chromium.org/2938543006
Cr-Commit-Position: refs/heads/master@{#479314}
Committed: https://chromium.googlesource.com/chromium/src/+/4c9217a8f484ed4624f4ab103a2a8cdf8d8a515e

[nainar, 2017-06-14 01:39:38]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 01:40:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-06-14 01:40:35]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-06-14 01:40:36]

shend@, 

PTAL? Thanks!

[commit-bot: I haz the power, 2017-06-14 02:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 02:46:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-06-14 03:30:54]

lgtm with comment

https://codereview.chromium.org/2938543006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2938543006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:649: if
(!BorderVisuallyEqual(other) || !RadiiEqual(other) ||
Can this be generated as well?

[nainar, 2017-06-14 04:57:02]

https://codereview.chromium.org/2938543006/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (right):

https://codereview.chromium.org/2938543006/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:649: if
(!BorderVisuallyEqual(other) || !RadiiEqual(other) ||
On 2017/06/14 at 03:30:54, shend wrote:
> Can this be generated as well?

Going to do this in a separate CL at a future time as BorderVisuallyEqual
depends on >21 properties :(

[nainar, 2017-06-14 05:19:25]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 05:19:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 07:06:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 07:06:53]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-06-14 07:16:04]

The CQ bit was checked by nainar@chromium.org

[nainar, 2017-06-14 07:16:04]

The patchset sent to the CQ was uploaded after l-g-t-m from shend@chromium.org
Link to the patchset: https://codereview.chromium.org/2938543006/#ps20001
(title: "Merge branch 'rareNonInheritedDataDiff' into otherGroups")

[commit-bot: I haz the power, 2017-06-14 07:16:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 07:20:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497424564152600,
"parent_rev": "c4efddc762cbbfb2bce13cfcb49a1e9a589de079", "commit_rev":
"4c9217a8f484ed4624f4ab103a2a8cdf8d8a515e"}

[commit-bot: I haz the power, 2017-06-14 07:21:06]

Description was changed from

==========
Remove references to groups directly stored on ComputedStyle in .cpp file

This patch ensures that there are no references to the following groups
in ComputedStyle.cpp:
1. BoxData
2. BackgroundData
3. VisualData
4. SurroundData
5. InheritedData
6. RareInheritedData

RareNonInheritedData is left to a separate CL

Diff: https://gist.github.com/nainar/0052646dd5dbb1b50af360551122b442/revisions

BUG=710938
==========

to

==========
Remove references to groups directly stored on ComputedStyle in .cpp file

This patch ensures that there are no references to the following groups
in ComputedStyle.cpp:
1. BoxData
2. BackgroundData
3. VisualData
4. SurroundData
5. InheritedData
6. RareInheritedData

RareNonInheritedData is left to a separate CL

Diff: https://gist.github.com/nainar/0052646dd5dbb1b50af360551122b442/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2938543006
Cr-Commit-Position: refs/heads/master@{#479314}
Committed:
https://chromium.googlesource.com/chromium/src/+/4c9217a8f484ed4624f4ab103a2a...
==========

[commit-bot: I haz the power, 2017-06-14 07:21:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4c9217a8f484ed4624f4ab103a2a...