Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2938543003: Remove almost all Javascript calls to setColorProfile (Closed)

Created:
3 years, 6 months ago by ccameron
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, shans, rjwright, posciak+watch_chromium.org, blink-reviews-animation_chromium.org, mlamouri+watch-blink_chromium.org, dcheng, feature-media-reviews_chromium.org, eric.carlson_apple.com, darktears, blink-reviews, Srirama, Eric Willigers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove almost all Javascript calls to setColorProfile We're using virtual test suites to test different color profiles, not Javascript APIs. We may keep these for just the gamut query tests. TBR=enne BUG=731783 Review-Url: https://codereview.chromium.org/2938543003 Cr-Commit-Position: refs/heads/master@{#478915} Committed: https://chromium.googlesource.com/chromium/src/+/f83728155df4b26ad4cd2eed5238eb109b74c609

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -311 lines) Patch
M third_party/WebKit/LayoutTests/images/color-profile-animate.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-animate-rotate.html View 2 chunks +0 lines, -9 lines 1 comment Download
M third_party/WebKit/LayoutTests/images/color-profile-background-clip-text.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-background-image-cover.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-background-image-cross-fade.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-background-image-cross-fade-png.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-background-image-repeat.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-background-image-space.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-border-fade.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-border-image.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-border-image-source.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-border-radius.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-clip.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-drag-image.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-filter.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-group.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-iframe.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-canvas.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-canvas-pattern.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-canvas-svg.html View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-filter-all.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-object-fit.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-profile-match.html View 1 chunk +1 line, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-pseudo-content.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-shape.html View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-image-svg-resource-url.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-layer.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-layer-filter.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-mask-image-svg.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-object.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-reflection.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-svg.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-svg-fill-text.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/color-profile-svg-foreign-object.html View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/images/resources/color-checker-munsell-chart.js View 1 chunk +1 line, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-poster-image.html View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-seek.html View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-seek-filter.html View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/color-profile-video-seek-object-fit.html View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/resources/munsell-video-chart.js View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
ccameron
https://codereview.chromium.org/2938543003/diff/1/third_party/WebKit/LayoutTests/images/color-profile-animate-rotate.html File third_party/WebKit/LayoutTests/images/color-profile-animate-rotate.html (left): https://codereview.chromium.org/2938543003/diff/1/third_party/WebKit/LayoutTests/images/color-profile-animate-rotate.html#oldcode32 third_party/WebKit/LayoutTests/images/color-profile-animate-rotate.html:32: setTimeout(function() { testRunner.setColorProfile('colorSpin', new Function()) }, 100); Sort-of-reassured to ...
3 years, 6 months ago (2017-06-13 05:19:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938543003/1
3 years, 6 months ago (2017-06-13 06:43:38 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 06:49:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f83728155df4b26ad4cd2eed5238...

Powered by Google App Engine
This is Rietveld 408576698