Changes to metrics logging on translate UI in Android.

Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI
8) Add logic for translate declined (this was removed in another cl
by mistake).

BUG=720231
Review-Url: https://codereview.chromium.org/2938453004
Cr-Commit-Position: refs/heads/master@{#479306}
Committed: https://chromium.googlesource.com/chromium/src/+/73c615314462fcb1eb0774d9be2cbccfb5c38414

[ramyasharma, 2017-06-13 06:44:54]

Patchset #1 (id:1) has been deleted

[ramyasharma, 2017-06-13 06:45:38]

ramyasharma@chromium.org changed reviewers:
+ dfalcantara@chromium.org, isherman@chromium.org

[ramyasharma, 2017-06-13 06:45:38]

isherman@chromium.org: Please review changes in enums.xml and histogram.xml

dfalcantara@chromium.org: Please review changes in TranslateCompactInfobar

[ramyasharma, 2017-06-13 06:46:26]

The CQ bit was checked by ramyasharma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 06:46:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ramyasharma, 2017-06-13 07:19:10]

Patchset #1 (id:20001) has been deleted

[ramyasharma, 2017-06-13 07:20:05]

Description was changed from

==========
Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI

BUG=720231
==========

to

==========
Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI
8) Add logic for translate declined (this was removed in another cl
by mistake).

BUG=720231
==========

[ramyasharma, 2017-06-13 07:30:04]

Patchset #1 (id:40001) has been deleted

[gone, 2017-06-13 16:54:42]

dfalcantara@chromium.org changed reviewers:
+ mdjones@chromium.org

[gone, 2017-06-13 16:54:43]

Sending to matt again.

[mdjones, 2017-06-13 17:06:43]

infobar/ lgtm

[Ilya Sherman, 2017-06-13 21:30:30]

Am I correct in understanding that this is merely clarifying the existing
semantics of the enumerated labels (plus deprecating one label), and not
actually changing any semantics?  If so, LGTM.

[ramyasharma, 2017-06-14 02:53:15]

On 2017/06/13 21:30:30, Ilya Sherman wrote:
> Am I correct in understanding that this is merely clarifying the existing
> semantics of the enumerated labels (plus deprecating one label), and not
> actually changing any semantics?  If so, LGTM.

Thanks Mathew and Ilya.
Ilya, that is correct, this is just clarifying the existing enum labels.

[ramyasharma, 2017-06-14 02:53:38]

The CQ bit was checked by ramyasharma@chromium.org

[commit-bot: I haz the power, 2017-06-14 02:53:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 04:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 04:49:17]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ramyasharma, 2017-06-14 05:35:11]

The CQ bit was checked by ramyasharma@chromium.org

[commit-bot: I haz the power, 2017-06-14 05:35:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 06:27:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497418511703690,
"parent_rev": "79aa9c0e9171f2094180d2ce73a62b37b1820c72", "commit_rev":
"73c615314462fcb1eb0774d9be2cbccfb5c38414"}

[commit-bot: I haz the power, 2017-06-14 06:28:05]

Description was changed from

==========
Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI
8) Add logic for translate declined (this was removed in another cl
by mistake).

BUG=720231
==========

to

==========
Changes to metrics logging on translate UI in Android.

Based on discussions with the PM, following changes are being made:

1) Rename "Tab language clicked" to "Translation accepted by clicking
on tab language".
2) Make sure that when a language is picked from more languages,
it's logged in the Translate.CompactInfobar.Event histogram as
"Translation accepted by clicking on language in more languages"
3) Rename "Translate services declined" to "X is clicked without
a prior translation and without a choice of never translate"
4) Always translate clicked, Never translate clicked, Never
translate site clicked, Undo always translate -
update all 4 to end in "in the options menu"
5) Always translate snackbar impression, Never translate snackbar
impression, Never translate site snackbar impression, Cancel
clicked on always translate snackbar, Cancel clicked on never
translate this site snackbar, Cancel clicked on never translate
snackbar - update all 6 to end in
"when triggered from the options menu"
6) "Infobar closed" get rid off
7) Rename description "Translate.InfobarShown" to indicate
it's for the old UI
8) Add logic for translate declined (this was removed in another cl
by mistake).

BUG=720231

Review-Url: https://codereview.chromium.org/2938453004
Cr-Commit-Position: refs/heads/master@{#479306}
Committed:
https://chromium.googlesource.com/chromium/src/+/73c615314462fcb1eb0774d9be2c...
==========

[commit-bot: I haz the power, 2017-06-14 06:28:07]

Committed patchset #1 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/73c615314462fcb1eb0774d9be2c...