Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2938453003:
VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK. (Closed)
|
Created:
3 years, 6 months ago by brucedawson Modified:
3 years, 6 months ago Reviewers:
scottmg CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionVS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK
This change switches the VS 2017 package to use the 10.0.15063.0 SDK and
the second preview of VS 2017 Update 3.
Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.
Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):
vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
--add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
--passive
Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers
package.
Then wrl\event.h was patched to work around a problem with clang-cl
builds, as described towards the end of this bug:
https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-is-broken-bitsh-indirectly-references-no.html
The patched version of event.h is attached to this bug comment:
https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120
The packaging script was updated in https://chromium-review.googlesource.com/c/534353/
to support this version and was then run like this:
python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0
VS 2015 builds are still the default.
R=scottmg@chromium.org
BUG=682416, 727970, 683729
Review-Url: https://codereview.chromium.org/2938453003
Cr-Commit-Position: refs/heads/master@{#479555}
Committed: https://chromium.googlesource.com/chromium/src/+/6460371218a734a724df68694975882f22c52d31
Patch Set 1 #Patch Set 2 : Actually build with 2017... #Patch Set 3 : Patched event.h #Patch Set 4 : Reset the default compiler back to 2017 #Messages
Total messages: 31 (25 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK. BUG=683729 ========== to ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script had to be hacked to comment out references to the MFC redist directories and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970 ==========
brucedawson@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script had to be hacked to comment out references to the MFC redist directories and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970 ========== to ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970 ==========
Description was changed from ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970 ========== to ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970, 683729 ==========
Another day, another VS 2017 package. This uses the latest compiler package and also the latest SDK. The latest SDK is still broken (yay!) but only for clang-cl builds. This bug is fixed in the packaged version and if we do decide to depend on 15063 (we'll have to eventually) it will only inconvenience external users who build with clang-cl, who will have to apply the same event.h patch. In happier news, fixed statreg.h! Fixed code-gen! The default remains VS 2015.
lgtm
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1497483417581300,
"parent_rev": "dd68266fcef32bcb88046c2e795689ee95faf386", "commit_rev":
"6460371218a734a724df68694975882f22c52d31"}
Message was sent while issue was closed.
Description was changed from ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970, 683729 ========== to ========== VS 2017 Update 3 Preview 2 with 10.0.15063.0 SDK This change switches the VS 2017 package to use the 10.0.15063.0 SDK and the second preview of VS 2017 Update 3. Packaging was done on a Windows Server 2016 VM, cleanly created for this purpose. Compiler was packaged up by downloading the VS 2017 Update 3 Preview 1, from https://www.visualstudio.com/vs/preview/, and then running this command (executable name was different): vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive Then the Windows 10.0.15063.0 SDK installer was used to install the Debuggers package. Then wrl\event.h was patched to work around a problem with clang-cl builds, as described towards the end of this bug: https://developercommunity.visualstudio.com/content/problem/42961/15063-sdk-i... The patched version of event.h is attached to this bug comment: https://bugs.chromium.org/p/chromium/issues/detail?id=683729#c120 The packaging script was updated in https://chromium-review.googlesource.com/c/534353/ to support this version and was then run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 VS 2015 builds are still the default. R=scottmg@chromium.org BUG=682416, 727970, 683729 Review-Url: https://codereview.chromium.org/2938453003 Cr-Commit-Position: refs/heads/master@{#479555} Committed: https://chromium.googlesource.com/chromium/src/+/6460371218a734a724df68694975... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/6460371218a734a724df68694975... |
