Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2938433002: [ObjC ARC] Converts ios/chrome/today_extension:today_extension to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin, lody
CC:
chromium-reviews, extensions-reviews_chromium.org, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/today_extension:today_extension to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2938433002 Cr-Commit-Position: refs/heads/master@{#478931} Committed: https://chromium.googlesource.com/chromium/src/+/6c21aa5c18121238d62c7f0dadef2f504ed9eb6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -76 lines) Patch
M ios/chrome/today_extension/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/today_extension/interactive_label.mm View 5 chunks +16 lines, -14 lines 0 comments Download
M ios/chrome/today_extension/notification_center_url_button.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/chrome/today_extension/physical_web_optin_footer.mm View 6 chunks +11 lines, -10 lines 0 comments Download
M ios/chrome/today_extension/today_view_controller.mm View 5 chunks +39 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 16:49:19 UTC) #6
lody
lgtm
3 years, 6 months ago (2017-06-13 08:10:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938433002/1
3 years, 6 months ago (2017-06-13 08:12:19 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 08:17:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c21aa5c18121238d62c7f0dadef...

Powered by Google App Engine
This is Rietveld 408576698