DescriptionRevert of Dispatch unload event for swapped-out subframes. (patchset #2 id:20001 of https://codereview.chromium.org/2941783002/ )
Reason for revert:
This CL is responsible for https://crbug.com/733940
Original issue's description:
> Avoid unnecessary direct dispatching of unload events from RFI::OnSwapOut.
>
> There is no need to call DispatchUnloadEvent directly from
> RenderFrameImpl::OnSwapOut, because the unload events will
> be dispatched even without this call - this will happen via
> the following call chain:
> - Document::DispatchUnloadEvents
> - FrameLoader::DispatchUnloadEvent
> - LocalFrame::Detach
> - WebFrame::Swap
> - RenderFrameImpl::OnSwapOut
>
> This also means that the old TODO from the code doesn't need fixing - we
> already dispatch unload events for swapped out subframes.
>
> BUG=733314
> TEST=Manualy set main frame's window.onunload and verified it still fires.
>
> Review-Url: https://codereview.chromium.org/2941783002
> Cr-Commit-Position: refs/heads/master@{#479538}
> Committed: https://chromium.googlesource.com/chromium/src/+/6e8a61ba16f529f02841fb75a50f15ec45726411
TBR=creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=733314
Review-Url: https://codereview.chromium.org/2938423002
Cr-Commit-Position: refs/heads/master@{#480133}
Committed: https://chromium.googlesource.com/chromium/src/+/bfda1c11ee19e7ca8fe2c73d33db7ab9be9f5a36
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|