Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2938423002: Revert of Dispatch unload event for swapped-out subframes. (Closed)

Created:
3 years, 6 months ago by Łukasz Anforowicz
Modified:
3 years, 6 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Dispatch unload event for swapped-out subframes. (patchset #2 id:20001 of https://codereview.chromium.org/2941783002/ ) Reason for revert: This CL is responsible for https://crbug.com/733940 Original issue's description: > Avoid unnecessary direct dispatching of unload events from RFI::OnSwapOut. > > There is no need to call DispatchUnloadEvent directly from > RenderFrameImpl::OnSwapOut, because the unload events will > be dispatched even without this call - this will happen via > the following call chain: > - Document::DispatchUnloadEvents > - FrameLoader::DispatchUnloadEvent > - LocalFrame::Detach > - WebFrame::Swap > - RenderFrameImpl::OnSwapOut > > This also means that the old TODO from the code doesn't need fixing - we > already dispatch unload events for swapped out subframes. > > BUG=733314 > TEST=Manualy set main frame's window.onunload and verified it still fires. > > Review-Url: https://codereview.chromium.org/2941783002 > Cr-Commit-Position: refs/heads/master@{#479538} > Committed: https://chromium.googlesource.com/chromium/src/+/6e8a61ba16f529f02841fb75a50f15ec45726411 TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=733314 Review-Url: https://codereview.chromium.org/2938423002 Cr-Commit-Position: refs/heads/master@{#480133} Committed: https://chromium.googlesource.com/chromium/src/+/bfda1c11ee19e7ca8fe2c73d33db7ab9be9f5a36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Łukasz Anforowicz
Created Revert of Dispatch unload event for swapped-out subframes.
3 years, 6 months ago (2017-06-16 18:34:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938423002/1
3 years, 6 months ago (2017-06-16 18:34:43 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:55:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfda1c11ee19e7ca8fe2c73d33db...

Powered by Google App Engine
This is Rietveld 408576698