Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2938393003: Convert the preferred size from Viewport coordinates to Window coordinates (Closed)

Created:
3 years, 6 months ago by oshima
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert the preferred size from Viewport coordinates to Window coordinates BUG=734085 TEST=covered by unit test. See bug for manual test procedure. Review-Url: https://codereview.chromium.org/2938393003 Cr-Commit-Position: refs/heads/master@{#480114} Committed: https://chromium.googlesource.com/chromium/src/+/1a688b5cdec13a4e11895f665240c2a2f1f95537

Patch Set 1 : Convert the preferred size from Viewport coordinates to Window coordinates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M content/renderer/render_view_browsertest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
oshima
3 years, 6 months ago (2017-06-16 15:18:41 UTC) #4
dgozman
lgtm
3 years, 6 months ago (2017-06-16 16:54:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938393003/20001
3 years, 6 months ago (2017-06-16 17:49:32 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 19:00:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a688b5cdec13a4e11895f665240...

Powered by Google App Engine
This is Rietveld 408576698