Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2938383004: Make the linux_chromium_cfi_rel_ng trybot more useful. (Closed)

Created:
3 years, 6 months ago by pcc1
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the linux_chromium_cfi_rel_ng trybot more useful. This change causes the trybot to: - use ThinLTO - produce detailed diagnostics - produce symbolized stack traces. The goal is to reduce cycle times on the bot, as well as provide more details when it fails so that its results are more actionable. Tested by patching a bad cast into one of the base_unittests and sending a swarming job as described here: http://dev.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Run-a-test-built-locally-on-Swarming BUG=732652 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2938383004 Cr-Commit-Position: refs/heads/master@{#480983} Committed: https://chromium.googlesource.com/chromium/src/+/46233c2b5dc4e33ee7afd24799f2157e0daed2fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M testing/test_env.py View 4 chunks +11 lines, -5 lines 0 comments Download
M tools/mb/mb.py View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pcc1
3 years, 6 months ago (2017-06-17 03:55:13 UTC) #1
pcc1
Note that this depends on https://codereview.chromium.org/2943863002
3 years, 6 months ago (2017-06-17 03:55:32 UTC) #2
Dirk Pranke
lgtm
3 years, 6 months ago (2017-06-18 21:19:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938383004/1
3 years, 6 months ago (2017-06-20 20:24:13 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 22:11:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/46233c2b5dc4e33ee7afd24799f2...

Powered by Google App Engine
This is Rietveld 408576698