Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2938383002: Fix bad merge in refactoring (Closed)

Created:
3 years, 6 months ago by Bill Hesse
Modified:
3 years, 6 months ago
Reviewers:
Bob Nystrom, sortie
CC:
reviews_dartlang.org, Bob Nystrom
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bad merge in refactoring The land of https://codereview.chromium.org/2933973002 merged badly with https://codereview.chromium.org/2934243002/ BUG=https://github.com/dart-lang/sdk/issues/28955 R=sortie@google.com Committed: https://github.com/dart-lang/sdk/commit/f99509ad42ec50ba62e1dcafcfe99d1f33d61819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/testing/dart/command_output.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
3 years, 6 months ago (2017-06-16 08:09:15 UTC) #2
sortie
lgtm
3 years, 6 months ago (2017-06-16 08:10:38 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as f99509ad42ec50ba62e1dcafcfe99d1f33d61819 (presubmit successful).
3 years, 6 months ago (2017-06-16 08:11:01 UTC) #5
Bob Nystrom
3 years, 6 months ago (2017-06-16 16:31:57 UTC) #7
Message was sent while issue was closed.
LGTM! Sorry I got confused on that one.

Powered by Google App Engine
This is Rietveld 408576698