Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2938373002: Introduce CanNotContinueOnNextLine() for DoesContinueOnNextLine() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce CanNotContinueOnNextLine() for DoesContinueOnNextLine() This patch Introduces |CanNotContinueOnNextLine()| to unify duplicate in |DoesContinueOnNextLine()| for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2938373002 Cr-Commit-Position: refs/heads/master@{#480344} Committed: https://chromium.googlesource.com/chromium/src/+/a71bc9c49fcab9f532cd5852a4272014d5a3ac86

Patch Set 1 : 2017-06-16T16:18:00 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938373002/1
3 years, 6 months ago (2017-06-16 08:59:24 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-16 08:59:26 UTC) #9
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-16 09:00:36 UTC) #11
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-16 18:26:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938373002/1
3 years, 6 months ago (2017-06-17 03:02:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/481598)
3 years, 6 months ago (2017-06-17 03:10:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938373002/1
3 years, 6 months ago (2017-06-19 01:58:41 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 04:20:34 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a71bc9c49fcab9f532cd5852a427...

Powered by Google App Engine
This is Rietveld 408576698