|
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce CanNotContinueOnNextLine() for DoesContinueOnNextLine()
This patch Introduces |CanNotContinueOnNextLine()| to unify duplicate in
|DoesContinueOnNextLine()| for improving readability.
BUG=n/a
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2938373002
Cr-Commit-Position: refs/heads/master@{#480344}
Committed: https://chromium.googlesource.com/chromium/src/+/a71bc9c49fcab9f532cd5852a4272014d5a3ac86
Patch Set 1 : 2017-06-16T16:18:00 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-16T16:18:05 BUG= 2017-06-16T16:18:00 ========== to ========== Introduce CanNotContinueOnNextLine() for DoesContinueOnNextLine() This patch Introduces |CanNotContinueOnNextLine()| to unify duplicate in |DoesContinueOnNextLine()| for improving readability. BUG=n/a TEST=n/a; no behavior changes ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1497837511833890, "parent_rev": "cd4e730743d522affeae07a1280792359f7856b1", "commit_rev": "a71bc9c49fcab9f532cd5852a4272014d5a3ac86"}
Message was sent while issue was closed.
Description was changed from ========== Introduce CanNotContinueOnNextLine() for DoesContinueOnNextLine() This patch Introduces |CanNotContinueOnNextLine()| to unify duplicate in |DoesContinueOnNextLine()| for improving readability. BUG=n/a TEST=n/a; no behavior changes ========== to ========== Introduce CanNotContinueOnNextLine() for DoesContinueOnNextLine() This patch Introduces |CanNotContinueOnNextLine()| to unify duplicate in |DoesContinueOnNextLine()| for improving readability. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2938373002 Cr-Commit-Position: refs/heads/master@{#480344} Committed: https://chromium.googlesource.com/chromium/src/+/a71bc9c49fcab9f532cd5852a427... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a71bc9c49fcab9f532cd5852a427... |