Add new mark-non-secure-as options to chrome://flags on iOS

Add new mark-non-secure-as options to chrome://flags on iOS

We recently added new options for the MarkHttpAs setting. iOS does
not use about_flags.cc, instead specifying flags in about_flags.mm.

This CL adds the new MarkHttpAs flag settings to the iOS-specific
file.

BUG=733800
TEST=Navigate to chrome://flags/#mark-non-secure-as

Review-Url: https://codereview.chromium.org/2938273002
Cr-Commit-Position: refs/heads/master@{#480102}
Committed: https://chromium.googlesource.com/chromium/src/+/816f6790e1d58d4e25d224755fc6d3fa2cd887e7

[elawrence, 2017-06-16 00:52:05]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-06-16 00:52:12]

The CQ bit was unchecked by elawrence@chromium.org

[elawrence, 2017-06-16 00:54:51]

Patchset #1 (id:1) has been deleted

[elawrence, 2017-06-16 00:55:11]

Patchset #1 (id:20001) has been deleted

[elawrence, 2017-06-16 14:00:00]

elawrence@chromium.org changed reviewers:
+ rohitrao@chromium.org

[elawrence, 2017-06-16 14:00:01]

PTAL? This change mirrors a prior changelist that added the same options to the
Desktop/Android flags.

[rohitrao (ping after 24h), 2017-06-16 14:16:02]

lgtm

Who do you expect will be flipping this flag?  Is this something that you're
comfortable exposing to users in stable builds?

[elawrence, 2017-06-16 15:14:10]

On 2017/06/16 14:16:02, rohitrao (ping after 24h) wrote:
> lgtm

Thanks for the quick review!

> Who do you expect will be flipping this flag?  

The flag will be used by a mix of folks-- security sensitive users who want HTTP
marked as dangerous today, and by developers who want to test their sites
against the upcoming changes in Chrome 62 (where we'll enable the "Warn on
incognio and after editing" option by default via Finch rollout).

> Is this something that you're
> comfortable exposing to users in stable builds?

Yes, this flag has existed for over a year on Desktop builds, and I believe it
was simply an oversight that it wasn't available on iOS. (The desktop
about_flags.cc has numerous conditional defines that make it look like it's
compiled for iOS even though it isn't, and it includes a constant definition
kOsAll which is really kOsAllExceptIOS).

[elawrence, 2017-06-16 15:14:13]

The CQ bit was checked by elawrence@chromium.org

[commit-bot: I haz the power, 2017-06-16 15:14:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 18:19:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497626053763740,
"parent_rev": "78b03b6957876df0bb887486a085cc77c9b52898", "commit_rev":
"816f6790e1d58d4e25d224755fc6d3fa2cd887e7"}

[commit-bot: I haz the power, 2017-06-16 18:19:41]

Description was changed from

==========
Add new mark-non-secure-as options to chrome://flags on iOS

We recently added new options for the MarkHttpAs setting. iOS does
not use about_flags.cc, instead specifying flags in about_flags.mm.

This CL adds the new MarkHttpAs flag settings to the iOS-specific
file.

BUG=733800
TEST=Navigate to chrome://flags/#mark-non-secure-as
==========

to

==========
Add new mark-non-secure-as options to chrome://flags on iOS

We recently added new options for the MarkHttpAs setting. iOS does
not use about_flags.cc, instead specifying flags in about_flags.mm.

This CL adds the new MarkHttpAs flag settings to the iOS-specific
file.

BUG=733800
TEST=Navigate to chrome://flags/#mark-non-secure-as

Review-Url: https://codereview.chromium.org/2938273002
Cr-Commit-Position: refs/heads/master@{#480102}
Committed:
https://chromium.googlesource.com/chromium/src/+/816f6790e1d58d4e25d224755fc6...
==========

[commit-bot: I haz the power, 2017-06-16 18:19:42]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/816f6790e1d58d4e25d224755fc6...