Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2938203004: Revert of Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH. (Closed)

Created:
3 years, 6 months ago by findit-for-me
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul, Matt Giuca, tfarina, weidongg, Qiang(Joe) Xu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH. (patchset #8 id:330001 of https://codereview.chromium.org/2939693004/ ) Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 479851 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ExMjAxY2ViMTJiZmVkZjUxY2IxYzBlMDE4NzliZDM1MjFiYTg4YTcM Original issue's description: > Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH. > > |HALF| - Half App List. This mode is > entered when the user types into the search box from > peeking mode. > > |FULLSCREEN_ALL_APPS| - Fullscreen app list that > shows all apps. Entered by default in maximize and > side shelf modes. Also entered with an upward swipe > from |PEEKING|. > > |FULLSCREEN_SEARCH| - Fullscreen app list that > shows search results. Entered from > FULLSCREEN_ALL_APPS after text is entered in the > search box, or from upward swipe from |HALF|. > > Please note: all Mash support will come post 61 as > per crbug.com/726838 > > BUG=731892 > > Review-Url: https://codereview.chromium.org/2939693004 > Cr-Commit-Position: refs/heads/master@{#479851} > Committed: https://chromium.googlesource.com/chromium/src/+/a1201ceb12bfedf51cb1c0e01879bd3521ba88a7 TBR=vadimt@chromium.org,xiyuan@chromium.org,oshima@chromium.org,newcomer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=731892 Review-Url: https://codereview.chromium.org/2938203004 Cr-Commit-Position: refs/heads/master@{#479883} Committed: https://chromium.googlesource.com/chromium/src/+/cfa2b1f18a8c741f8e285d818fbcaed3c6595c59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -278 lines) Patch
M ash/app_list/app_list_presenter_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate.cc View 3 chunks +1 line, -32 lines 0 comments Download
M ash/app_list/app_list_presenter_delegate_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/app_list/demo/app_list_demo_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/presenter/app_list_presenter_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/all_apps_tile_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.h View 4 chunks +10 lines, -37 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 6 chunks +48 lines, -198 lines 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
findit-for-me
Created Revert of Added HALF, FULLSCREEN_ALL_APPS, and FULLSCREEN_SEARCH.
3 years, 6 months ago (2017-06-15 22:44:55 UTC) #1
findit-for-me
Sheriffs, CL owner or CL reviewers: Please confirm and "Quick L-G-T-M & CQ" this revert ...
3 years, 6 months ago (2017-06-15 22:44:58 UTC) #3
newcomer
lgtm
3 years, 6 months ago (2017-06-15 23:18:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938203004/1
3 years, 6 months ago (2017-06-15 23:18:59 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-15 23:19:01 UTC) #8
newcomer
Could with comitter status someone please lgtm this revert? Thanks, Alex
3 years, 6 months ago (2017-06-16 00:04:42 UTC) #9
vadimt
lgtm
3 years, 6 months ago (2017-06-16 00:05:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938203004/1
3 years, 6 months ago (2017-06-16 00:05:59 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 00:06:48 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfa2b1f18a8c741f8e285d818fbc...

Powered by Google App Engine
This is Rietveld 408576698