Make HostCache::RestoreFromListValue() take a const reference

Make HostCache::RestoreFromListValue() take a const reference

This was a bug in https://codereview.chromium.org/2791653002/.

BUG=605149
Review-Url: https://codereview.chromium.org/2938183003
Cr-Commit-Position: refs/heads/master@{#480107}
Committed: https://chromium.googlesource.com/chromium/src/+/120380c724ca5748ec6b1822121ca038c0f139df

[mgersh, 2017-06-15 14:07:34]

mgersh@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[Julia Tuttle, 2017-06-16 16:23:55]

lgtm with optional nit.

https://codereview.chromium.org/2938183003/diff/1/net/dns/host_cache.cc
File net/dns/host_cache.cc (right):

https://codereview.chromium.org/2938183003/diff/1/net/dns/host_cache.cc#newco...
net/dns/host_cache.cc:319: for (base::ListValue::const_iterator it =
old_cache.begin();
nit: You might be able to get away with "auto it" (or "auto& it", it's always
the second one I try) here, and it'd be less cluttered. Your choice though.

[mgersh, 2017-06-16 16:54:38]

https://codereview.chromium.org/2938183003/diff/1/net/dns/host_cache.cc
File net/dns/host_cache.cc (right):

https://codereview.chromium.org/2938183003/diff/1/net/dns/host_cache.cc#newco...
net/dns/host_cache.cc:319: for (base::ListValue::const_iterator it =
old_cache.begin();
On 2017/06/16 16:23:55, Julia Tuttle wrote:
> nit: You might be able to get away with "auto it" (or "auto& it", it's always
> the second one I try) here, and it'd be less cluttered. Your choice though.

Oh, I like that better, thanks.

[mgersh, 2017-06-16 16:54:41]

The CQ bit was checked by mgersh@chromium.org

[mgersh, 2017-06-16 16:54:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/2938183003/#ps20001
(title: "auto")

[commit-bot: I haz the power, 2017-06-16 16:55:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 18:25:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497632081841190,
"parent_rev": "91b1e2bd60a339bb26c253802a8992b215804a0e", "commit_rev":
"120380c724ca5748ec6b1822121ca038c0f139df"}

[commit-bot: I haz the power, 2017-06-16 18:25:42]

Description was changed from

==========
Make HostCache::RestoreFromListValue() take a const reference

This was a bug in https://codereview.chromium.org/2791653002/.

BUG=605149
==========

to

==========
Make HostCache::RestoreFromListValue() take a const reference

This was a bug in https://codereview.chromium.org/2791653002/.

BUG=605149

Review-Url: https://codereview.chromium.org/2938183003
Cr-Commit-Position: refs/heads/master@{#480107}
Committed:
https://chromium.googlesource.com/chromium/src/+/120380c724ca5748ec6b1822121c...
==========

[commit-bot: I haz the power, 2017-06-16 18:25:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/120380c724ca5748ec6b1822121c...