Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

CollectSelectedMap() collects LayoutObjects and LayoutBlocks that removed for-while-loop iterates.
Then we can unify their Rect.

BUG=708453
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2938133002
Cr-Commit-Position: refs/heads/master@{#479643}
Committed: https://chromium.googlesource.com/chromium/src/+/6b583e8e663c6afb2a9ceffaaad6b54637bdd8fc

[yoichio, 2017-06-15 01:54:40]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 01:54:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 02:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 02:12:24]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yoichio, 2017-06-15 07:19:13]

PTAL

[yoichio, 2017-06-15 07:19:31]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 07:19:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 07:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 07:27:36]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-06-15 07:39:23]

Description was changed from

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

BUG=708453
TEST=No change in behavior
==========

to

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

BUG=708453
TEST=No change in behavior
==========

[yoichio, 2017-06-15 07:39:23]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-06-15 08:18:39]

Code change itself is OK.

But, I don't understand why this change yields same result as before.

Could you explain why this change yield same results in description?
It seems this change uses new algorithm to produces same result rather than
refactoring.

[yosin_UTC9, 2017-06-15 08:20:42]

On 2017/06/15 at 08:18:39, yosin_UTC9 wrote:
> Code change itself is OK.
> 
> But, I don't understand why this change yields same result as before.
> 
> Could you explain why this change yield same results in description?
> It seems this change uses new algorithm to produces same result rather than
refactoring.

Oh, I see CollectSelectedMap() does what this for-while-loop does.

[yoichio, 2017-06-15 08:27:46]

Description was changed from

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

BUG=708453
TEST=No change in behavior
==========

to

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

CollectSelectedMap() collect LayoutObjects and LayoutBlocks that removed
for-while-loop iterates.
Then we can unify their Rect.

BUG=708453
TEST=No change in behavior
==========

[yoichio, 2017-06-15 08:27:54]

Description was changed from

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

CollectSelectedMap() collect LayoutObjects and LayoutBlocks that removed
for-while-loop iterates.
Then we can unify their Rect.

BUG=708453
TEST=No change in behavior
==========

to

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

CollectSelectedMap() collects LayoutObjects and LayoutBlocks that removed
for-while-loop iterates.
Then we can unify their Rect.

BUG=708453
TEST=No change in behavior
==========

[yoichio, 2017-06-15 08:28:13]

Update description

[yosin_UTC9, 2017-06-15 08:35:20]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-06-15 08:35:21]

lgtm

[commit-bot: I haz the power, 2017-06-15 08:35:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 08:39:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497515720636030, "parent_rev":
"4873f6cb2f8c674cbf7529b69820cd58c2d4df1f", "commit_rev":
"6b583e8e663c6afb2a9ceffaaad6b54637bdd8fc"}

[commit-bot: I haz the power, 2017-06-15 08:39:30]

Description was changed from

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

CollectSelectedMap() collects LayoutObjects and LayoutBlocks that removed
for-while-loop iterates.
Then we can unify their Rect.

BUG=708453
TEST=No change in behavior
==========

to

==========
Refactor LayoutSelection::SelectionBounds() with CollectSelectedMap().

CollectSelectedMap() collects LayoutObjects and LayoutBlocks that removed
for-while-loop iterates.
Then we can unify their Rect.

BUG=708453
TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2938133002
Cr-Commit-Position: refs/heads/master@{#479643}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b583e8e663c6afb2a9ceffaaad6...
==========

[commit-bot: I haz the power, 2017-06-15 08:39:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b583e8e663c6afb2a9ceffaaad6...