Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2938123002: Revert of [Android] Adding Smart GO/NEXT feature in Chrome (Closed)

Created:
3 years, 6 months ago by kochi
Modified:
3 years, 6 months ago
CC:
aelias_OOO_until_Jul13, agrieve+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Ted C
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Adding Smart GO/NEXT feature in Chrome (patchset #26 id:500001 of https://codereview.chromium.org/2839993002/ ) Reason for revert: This caused several clusterfuzz bugs (733197, 733218, 733282) - let me revert for investigation on those. Original issue's description: > [Android] Adding Smart GO/NEXT feature in Chrome > > Smart Go/Next brings better user experience to the user during form submitting applications. > For navigating between form elements, user can use NEXT/PREVIOUS button from IME > without touching on individual fields. This will avoid unnecessary form submissions before > filling or visiting all fields in the form. > > Additionally it will save user time and avoid redundant network requests before actually > filling/attending entire fields in the form > > Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing > > BUG=410785, 648986 > > Review-Url: https://codereview.chromium.org/2839993002 > Cr-Commit-Position: refs/heads/master@{#479126} > Committed: https://chromium.googlesource.com/chromium/src/+/8d80ad1410dcb23f55c323a97e57eed750a611dc TBR=tkent@chromium.org,changwan@chromium.org,dcheng@chromium.org,ekaramad@chromium.org,nasko@chromium.org,yosin@chromium.org,aelias@chromium.org,ajith.v@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=410785, 648986 Review-Url: https://codereview.chromium.org/2938123002 Cr-Commit-Position: refs/heads/master@{#479601} Committed: https://chromium.googlesource.com/chromium/src/+/76fc114441c30b033be4b3aa74dba49eba5ad072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -784 lines) Patch
M content/browser/android/ime_adapter_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/android/ime_adapter_android.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 3 chunks +8 lines, -24 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java View 3 chunks +14 lines, -15 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java View 3 chunks +3 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +0 lines, -64 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java View 5 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M content/test/data/android/input/input_forms.html View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 3 chunks +0 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 2 chunks +0 lines, -483 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_disabled_and_readonly_elements.html View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_key_event_listeners.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/advance_focus_in_form_with_tabindex_elements.html View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebFocusType.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/WebTextInputType.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kochi
Created Revert of [Android] Adding Smart GO/NEXT feature in Chrome
3 years, 6 months ago (2017-06-15 01:47:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938123002/1
3 years, 6 months ago (2017-06-15 01:47:33 UTC) #3
yosin_UTC9
lgtm Is it better to split this patch?
3 years, 6 months ago (2017-06-15 03:38:45 UTC) #4
yosin_UTC9
On 2017/06/15 at 03:38:45, yosin_UTC9 wrote: > lgtm > > Is it better to split ...
3 years, 6 months ago (2017-06-15 03:39:05 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 04:25:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76fc114441c30b033be4b3aa74db...

Powered by Google App Engine
This is Rietveld 408576698