Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Issue 2938113002: Improvements to our windows accessibility tree testing. (Closed)

Created:
3 years, 6 months ago by dougt
Modified:
3 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, dougt+watch_chromium.org, darin-cc_chromium.org, aleventhal+watch_chromium.org, dtseng+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improvements to our windows accessibility tree testing. This cl makes two changes. First it makes private some BrowserAccessibilityWin accessors. Clients should use the public COM API when accessing state/roles/etc. Second, I am also modifying AccessibilityTreeFormatterWin to use the public COM API. This works for the most part, but the formatter still needs access to the role name as well as some positioning information. BUG=733437 Review-Url: https://codereview.chromium.org/2938113002 Cr-Commit-Position: refs/heads/master@{#479620} Committed: https://chromium.googlesource.com/chromium/src/+/5859af4f6c0c07cf97069fdbe5d40afb40a7ad17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -25 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_win.cc View 3 chunks +40 lines, -18 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_com_win.h View 3 chunks +10 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
dougt
dmazzoni, ptal.
3 years, 6 months ago (2017-06-15 00:32:54 UTC) #7
dougt
dmazzoni, ptal.
3 years, 6 months ago (2017-06-15 00:32:55 UTC) #8
dmazzoni
lgtm
3 years, 6 months ago (2017-06-15 06:07:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938113002/1
3 years, 6 months ago (2017-06-15 06:07:30 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 06:12:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5859af4f6c0c07cf97069fdbe5d4...

Powered by Google App Engine
This is Rietveld 408576698