Persist core system profile during startup.

Persist core system profile during startup.

Almost 40% of persistent metrics files are missing the embedded system
profile which is stored about 1 minute into the process lifetime when
the initial metrics upload is sent.

This distinguishes between basic and complete system profiles allowing
the core profile to be stored when the Log is created and be replaced by
a more complete version later.  Thus basic profile will thus be available
even if the browser crashes almost immediately.

BUG=695880
Review-Url: https://codereview.chromium.org/2938013002
Cr-Commit-Position: refs/heads/master@{#479513}
Committed: https://chromium.googlesource.com/chromium/src/+/8ccb6aa1a42c3e72c4348b80932679b7ac6edb21

[bcwhite, 2017-06-14 18:31:05]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 18:31:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-06-14 18:32:27]

Description was changed from

==========
Persist core system profile during startup.

Almost 40% of persistent metrics files are missing the embedded system
profile which is stored about 1 minute into the process lifetime when
the initial metrics upload is sent.

This distinguishes between basic and complete system profiles allowing
the core profile to be stored when the Log is created to be replaced by
a more complete version later.  Thus basic profile will thus be available
immediately with the more complete one to follow.

BUG=695880
==========

to

==========
Persist core system profile during startup.

Almost 40% of persistent metrics files are missing the embedded system
profile which is stored about 1 minute into the process lifetime when
the initial metrics upload is sent.

This distinguishes between basic and complete system profiles allowing
the core profile to be stored when the Log is created and be replaced by
a more complete version later.  Thus basic profile will thus be available
even if the browser crashes almost immediately.

BUG=695880
==========

[commit-bot: I haz the power, 2017-06-14 18:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 18:40:17]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[bcwhite, 2017-06-14 18:48:16]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 18:48:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-06-14 18:52:08]

The CQ bit was checked by bcwhite@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 18:52:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-06-14 18:52:14]

Patchset #2 (id:20001) has been deleted

[bcwhite, 2017-06-14 19:31:50]

bcwhite@chromium.org changed reviewers:
+ asvitkine@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:26:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:26:45]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Alexei Svitkine (slow), 2017-06-14 20:36:37]

lgtm

I'm curious if there are things in the system profile that we should move
earlier so they're part of the initial incomplete profile, but I guess we can
figure those out later.

Also, it's kind of unfortunate that MetricsLog is reaching into the global
allocator for this. (I realise that this was from the previous CL - but still
would be better to make it a ctor param instead - but I'm OK with doing that in
a follow-up CL.)

[bcwhite, 2017-06-14 20:52:10]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:52:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bcwhite, 2017-06-14 21:06:31]

> I'm curious if there are things in the system profile that we should move
> earlier so they're part of the initial incomplete profile, but I guess we can
> figure those out later.

I can add field trials to it when they're first accessed and perhaps other
things, too, thus keeping it "up to date" as the system evolves.


> Also, it's kind of unfortunate that MetricsLog is reaching into the global
> allocator for this. (I realise that this was from the previous CL - but still
> would be better to make it a ctor param instead - but I'm OK with doing that
in
> a follow-up CL.)

There's a singleton GlobalPersistentSystemProfile into which the file's
PersistentMemeoryAllocator is registered so there is a level of abstraction.  It
also means the same system profile can be stored in the breadcrumbs file because
it registers itself into that global object as well.

[Alexei Svitkine (slow), 2017-06-14 21:15:47]

On Wed, Jun 14, 2017 at 5:06 PM, <bcwhite@chromium.org> wrote:

> > I'm curious if there are things in the system profile that we should move
> > earlier so they're part of the initial incomplete profile, but I guess
> we can
> > figure those out later.
>
> I can add field trials to it when they're first accessed and perhaps other
> things, too, thus keeping it "up to date" as the system evolves.
>

Ah, yes we'd definitely want up-to-date field trials. At least, capturing
them at the time the log object is created would probably be a good first
step.


>
>
>
> > Also, it's kind of unfortunate that MetricsLog is reaching into the
> global
> > allocator for this. (I realise that this was from the previous CL - but
> still
> > would be better to make it a ctor param instead - but I'm OK with doing
> that
> in
> > a follow-up CL.)
>
> There's a singleton GlobalPersistentSystemProfile into which the file's
> PersistentMemeoryAllocator is registered so there is a level of
> abstraction. It
> also means the same system profile can be stored in the breadcrumbs file
> because
> it registers itself into that global object as well.
>

Ah, right - it's not the allocated by the global persistent system profile.
I guess that's
not too bad.


>
> https://codereview.chromium.org/2938013002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-06-14 21:45:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1497473530624820,
"parent_rev": "bb678d09c95613f126135e1f96854a0d83241361", "commit_rev":
"8ccb6aa1a42c3e72c4348b80932679b7ac6edb21"}

[commit-bot: I haz the power, 2017-06-14 21:45:20]

Description was changed from

==========
Persist core system profile during startup.

Almost 40% of persistent metrics files are missing the embedded system
profile which is stored about 1 minute into the process lifetime when
the initial metrics upload is sent.

This distinguishes between basic and complete system profiles allowing
the core profile to be stored when the Log is created and be replaced by
a more complete version later.  Thus basic profile will thus be available
even if the browser crashes almost immediately.

BUG=695880
==========

to

==========
Persist core system profile during startup.

Almost 40% of persistent metrics files are missing the embedded system
profile which is stored about 1 minute into the process lifetime when
the initial metrics upload is sent.

This distinguishes between basic and complete system profiles allowing
the core profile to be stored when the Log is created and be replaced by
a more complete version later.  Thus basic profile will thus be available
even if the browser crashes almost immediately.

BUG=695880

Review-Url: https://codereview.chromium.org/2938013002
Cr-Commit-Position: refs/heads/master@{#479513}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ccb6aa1a42c3e72c4348b809326...
==========

[commit-bot: I haz the power, 2017-06-14 21:45:21]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8ccb6aa1a42c3e72c4348b809326...