Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2938003002: Turn on network time querying (on demand only) by default (Closed)

Created:
3 years, 6 months ago by estark
Modified:
3 years, 6 months ago
Reviewers:
rkaplow, meacer
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on network time querying (on demand only) by default BUG=589700 Review-Url: https://codereview.chromium.org/2938003002 Cr-Commit-Position: refs/heads/master@{#480073} Committed: https://chromium.googlesource.com/chromium/src/+/0394c1517ae1eccd458c1a21d0253a9b493b0c8b

Patch Set 1 #

Patch Set 2 : fix stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M components/network_time/network_time_tracker.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
estark
meacer, PTAL?
3 years, 6 months ago (2017-06-14 20:11:25 UTC) #8
estark
and +rkaplow for testing/
3 years, 6 months ago (2017-06-14 20:14:30 UTC) #10
meacer
LGTM and godspeed.
3 years, 6 months ago (2017-06-14 20:38:23 UTC) #11
estark
Friendly ping to rkaplow
3 years, 6 months ago (2017-06-16 05:07:50 UTC) #12
rkaplow
lgtm
3 years, 6 months ago (2017-06-16 14:04:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938003002/20001
3 years, 6 months ago (2017-06-16 15:05:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/451349)
3 years, 6 months ago (2017-06-16 15:55:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938003002/20001
3 years, 6 months ago (2017-06-16 16:13:11 UTC) #19
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 16:51:58 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0394c1517ae1eccd458c1a21d025...

Powered by Google App Engine
This is Rietveld 408576698