Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2937943002: [deoptimizer] Fix printing of uint32 values. (Closed)

Created:
3 years, 6 months ago by Jarin
Modified:
3 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Fix printing of uint32 values. Review-Url: https://codereview.chromium.org/2937943002 Cr-Commit-Position: refs/heads/master@{#45945} Committed: https://chromium.googlesource.com/v8/v8/+/b267efc706520be894b4f09bf2f63fd7401ca607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/deoptimizer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Jarin
Could you take a look, please?
3 years, 6 months ago (2017-06-14 11:52:11 UTC) #2
Michael Starzinger
LGTM. Thanks!
3 years, 6 months ago (2017-06-14 12:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937943002/1
3 years, 6 months ago (2017-06-14 12:16:38 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 12:44:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b267efc706520be894b4f09bf2f63fd7401...

Powered by Google App Engine
This is Rietveld 408576698