Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2937863002: Rewrite editing/inserting/typing-at-end-of-line.html to utilize assert_selection() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite editing/inserting/typing-at-end-of-line.html to utilize assert_selection() This patch changes "editing/inserting/typing-at-end-of-line.html" to utilize |assert_selection()| for ease of maintaining test case. BUG=731756 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2937863002 Cr-Commit-Position: refs/heads/master@{#479317} Committed: https://chromium.googlesource.com/chromium/src/+/1942e80bb847dacadbc3b36463db5cb2098e987a

Patch Set 1 : 2017-06-14T12:50:16 #

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-14 06:27:48 UTC) #7
yoichio
lgtm
3 years, 6 months ago (2017-06-14 07:17:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937863002/1
3 years, 6 months ago (2017-06-14 07:20:21 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 07:26:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1942e80bb847dacadbc3b36463db...

Powered by Google App Engine
This is Rietveld 408576698