Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2937783003: Rewrite editing/inserting/edited-whitespace-1.html to utilize assert_selection() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews, mac-reviews_chromium.org, skobes
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite editing/inserting/edited-whitespace-1.html to utilize assert_selection() This patch changes "editing/inserting/edited-whitespace-1.html" to utilize |assert_selection()| for ease of maintaining test case. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/527421: Fix contentEditable treatment of double spaces BUG=731756 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2937783003 Cr-Commit-Position: refs/heads/master@{#479322} Committed: https://chromium.googlesource.com/chromium/src/+/33321455a76da87330f5770ce092be8a06fd5df8

Patch Set 1 : 2017-06-14T11:26:17 #

Total comments: 2

Patch Set 2 : 2017-06-14T15:25:45 #

Messages

Total messages: 21 (15 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-14 03:49:32 UTC) #10
yoichio
https://codereview.chromium.org/2937783003/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html File third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html (right): https://codereview.chromium.org/2937783003/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html#newcode7 third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html:7: '<div contenteditable style="border: 1px solid black; width: 60px;">|</div>', Is ...
3 years, 6 months ago (2017-06-14 05:57:11 UTC) #11
yosin_UTC9
PTAL https://codereview.chromium.org/2937783003/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html File third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html (right): https://codereview.chromium.org/2937783003/diff/20001/third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html#newcode7 third_party/WebKit/LayoutTests/editing/inserting/edited-whitespace-1.html:7: '<div contenteditable style="border: 1px solid black; width: 60px;">|</div>', ...
3 years, 6 months ago (2017-06-14 06:26:49 UTC) #13
yoichio
lgtm
3 years, 6 months ago (2017-06-14 07:11:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937783003/40001
3 years, 6 months ago (2017-06-14 07:20:37 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 07:59:42 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/33321455a76da87330f5770ce092...

Powered by Google App Engine
This is Rietveld 408576698