Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2937713002: Fix text alignment issue in Chrome iOS' omnibox. (Closed)

Created:
3 years, 6 months ago by justincohen
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, jdonnelly+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix text alignment issue in Chrome iOS' omnibox. |preEditTextAlignment| does not need to honor RTL, as URLs are always left aligned. BUG=575181 Review-Url: https://codereview.chromium.org/2937713002 Cr-Commit-Position: refs/heads/master@{#479701} Committed: https://chromium.googlesource.com/chromium/src/+/f54107635ab356843ffa12e9d38682408ea00ffe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
rohitrao (ping after 24h)
lgtm
3 years, 6 months ago (2017-06-15 14:47:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937713002/1
3 years, 6 months ago (2017-06-15 14:48:14 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 15:01:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f54107635ab356843ffa12e9d386...

Powered by Google App Engine
This is Rietveld 408576698