Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 2937693003: Make luci-go compile again after deps.lock roll. (Closed)

Created:
3 years, 6 months ago by Vadim Sh.
Modified:
3 years, 6 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Make luci-go compile again after deps.lock roll. google.golang.org/api/logging/v1beta3 doesn't exist anymore, and v2 API is structurally a bit different. It appears, nothing non-dead is really using Cloud Logging stuff in LUCI anymore, so it is simpler just to remove the code. protoc changed format of the top comment, it broke cproto tests. R=dnj@chromium.org, hinoka@chromium.org, tandrii@chromium.org BUG= Review-Url: https://codereview.chromium.org/2937693003 Committed: https://github.com/luci/luci-go/commit/738aa96c1ba5e86699386f775d521b50d5cc81c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1262 lines) Patch
D common/cloudlogging/buffer.go View 1 chunk +0 lines, -224 lines 0 comments Download
D common/cloudlogging/buffer_test.go View 1 chunk +0 lines, -227 lines 0 comments Download
D common/cloudlogging/client.go View 1 chunk +0 lines, -225 lines 0 comments Download
D common/cloudlogging/client_test.go View 1 chunk +0 lines, -204 lines 0 comments Download
D common/cloudlogging/entry.go View 1 chunk +0 lines, -65 lines 0 comments Download
D common/cloudlogging/severity.go View 1 chunk +0 lines, -63 lines 0 comments Download
D common/logging/cloudlog/logging.go View 1 chunk +0 lines, -162 lines 0 comments Download
D common/logging/cloudlog/logging_test.go View 1 chunk +0 lines, -61 lines 0 comments Download
M grpc/cmd/cproto/testdata/helloworld/test.pb.golden View 1 chunk +1 line, -2 lines 0 comments Download
M grpc/cmd/cproto/testdata/importGoogle/test.pb.golden View 1 chunk +1 line, -2 lines 0 comments Download
M grpc/cmd/cproto/testdata/twoFiles/1.pb.golden View 1 chunk +1 line, -2 lines 0 comments Download
M grpc/cmd/cproto/testdata/twoFiles/2.pb.golden View 1 chunk +1 line, -2 lines 0 comments Download
M milo/appengine/common/middleware.go View 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Vadim Sh.
3 years, 6 months ago (2017-06-13 23:23:43 UTC) #1
dnj
lgtm
3 years, 6 months ago (2017-06-14 00:16:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937693003/1
3 years, 6 months ago (2017-06-14 00:18:53 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 00:25:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/738aa96c1ba5e86699386f775d521b50d5cc81c6

Powered by Google App Engine
This is Rietveld 408576698