[ia32][wasm] Add I8x16/I16x8 Splat/ExtractLane/ReplaceLane

[ia32][wasm] Add I8x16/I16x8 Splat/ExtractLane/ReplaceLane

Add Pxor, Pshuflw, Pshufb, Pextrb, Pextrw macros
Reconstruct SIMD opcodes to macros

BUG=

Review-Url: https://codereview.chromium.org/2937653002
Cr-Commit-Position: refs/heads/master@{#46400}
Committed: https://chromium.googlesource.com/v8/v8/+/23c2edd42b003a00aab6b4a249d1861cf7e877cc

[Jing, 2017-06-13 06:13:26]

jing.bao@intel.com changed reviewers:
+ bbudge@chromium.org, bmeurer@chromium.org, mtrofin@chromium.org

[Jing, 2017-06-13 06:13:26]

For the v8_android_chromium_gn_dbg check failure, it seems unrelated to my
patch, so I publish it for review

[bbudge, 2017-06-13 22:08:21]

https://codereview.chromium.org/2937653002/diff/1/src/compiler/ia32/code-gene...
File src/compiler/ia32/code-generator-ia32.cc (right):

https://codereview.chromium.org/2937653002/diff/1/src/compiler/ia32/code-gene...
src/compiler/ia32/code-generator-ia32.cc:1903: case kIA32I16x8Splat: {
Follow the order in wasm-opcodes.h.

https://codereview.chromium.org/2937653002/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-codes-ia32.h (right):

https://codereview.chromium.org/2937653002/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-codes-ia32.h:120: V(SSEI32x4ReplaceLane)          
\
Could you order the opcodes as they are in wasm-opcodes.h? There, they are
ordered primarily by vector type, number of parameters, etc., so for example,
I32x4ReplaceLane would follow I32x4ExtractLane.

https://codereview.chromium.org/2937653002/diff/1/src/compiler/ia32/instructi...
File src/compiler/ia32/instruction-scheduler-ia32.cc (right):

https://codereview.chromium.org/2937653002/diff/1/src/compiler/ia32/instructi...
src/compiler/ia32/instruction-scheduler-ia32.cc:102: case kIA32I16x8Splat:
Ordering.

[Jing, 2017-06-14 02:48:52]

Reordered the opcodes. Are they in the right order now?

[bbudge, 2017-06-14 16:28:45]

On 2017/06/14 02:48:52, Jing wrote:
> Reordered the opcodes. Are they in the right order now?

Sorry I was a little vague. The ordering for F32x4 is like this:

  V(F32x4Splat)                 
  V(F32x4ExtractLane)           
  V(F32x4ReplaceLane)           
  V(F32x4SConvertI32x4)         
  V(F32x4UConvertI32x4)         
  V(F32x4Abs)                   
  V(F32x4Neg)                   
  V(F32x4RecipApprox)           
  V(F32x4RecipSqrtApprox)       
  V(F32x4Add)                   
  V(F32x4AddHoriz)              
  V(F32x4Sub)                   
  V(F32x4Mul)                   
  V(F32x4Min)                   
  V(F32x4Max)                  
  V(F32x4Eq)                    
  V(F32x4Ne)                    
  V(F32x4Lt)                    
  V(F32x4Le)                    
  V(F32x4Gt)                    
  V(F32x4Ge)                    

So the order is Splat, ExtractLane, ReplaceLane, {unary ops}, {binary ops},
{relational ops}

When in doubt match what is in src/compiler/opcodes.h:

https://cs.chromium.org/chromium/src/v8/src/compiler/opcodes.h?rcl=ef21bee476...

[Jing, 2017-06-15 02:10:53]

Is that what you mean?

[bbudge, 2017-06-16 21:55:19]

LGTM Thanks!

[Jing, 2017-06-21 03:08:17]

Hi Benedikt and Trofin,PTAL.Thanks！

[Jing, 2017-06-27 02:08:31]

On 2017/06/21 03:08:17, Jing wrote:
> Hi Benedikt and Trofin,PTAL.Thanks！

Ping Benedikt and Trofin, PTAL. Thanks!

[Jing, 2017-07-04 05:18:27]

On 2017/06/27 02:08:31, Jing wrote:
> On 2017/06/21 03:08:17, Jing wrote:
> > Hi Benedikt and Trofin,PTAL.Thanks！
> 
> Ping Benedikt and Trofin, PTAL. Thanks!

Ping again.

[Benedikt Meurer, 2017-07-05 04:06:05]

sorry for the delay. LGTM!

[Jing, 2017-07-05 05:10:45]

The CQ bit was checked by jing.bao@intel.com

[Jing, 2017-07-05 05:10:45]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2937653002/#ps80001
(title: "Rebase 2")

[commit-bot: I haz the power, 2017-07-05 05:10:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-05 05:38:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499231445170770,
"parent_rev": "7b4e940ae078a74f6ad5ba56f6780edd676bc152", "commit_rev":
"23c2edd42b003a00aab6b4a249d1861cf7e877cc"}

[commit-bot: I haz the power, 2017-07-05 05:38:16]

Description was changed from

==========
[ia32][wasm] Add I8x16/I16x8 Splat/ExtractLane/ReplaceLane

Add Pxor, Pshuflw, Pshufb, Pextrb, Pextrw macros
Reconstruct SIMD opcodes to macros

BUG=
==========

to

==========
[ia32][wasm] Add I8x16/I16x8 Splat/ExtractLane/ReplaceLane

Add Pxor, Pshuflw, Pshufb, Pextrb, Pextrw macros
Reconstruct SIMD opcodes to macros

BUG=

Review-Url: https://codereview.chromium.org/2937653002
Cr-Commit-Position: refs/heads/master@{#46400}
Committed:
https://chromium.googlesource.com/v8/v8/+/23c2edd42b003a00aab6b4a249d1861cf7e...
==========

[commit-bot: I haz the power, 2017-07-05 05:38:18]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/23c2edd42b003a00aab6b4a249d1861cf7e...