Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2937633003: Revert of Fix a race condition in ~RegistryHashStoreContentsWin (Closed)

Created:
3 years, 6 months ago by DaleCurtis
Modified:
3 years, 6 months ago
Reviewers:
proberge, gab
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a race condition in ~RegistryHashStoreContentsWin (patchset #9 id:180001 of https://codereview.chromium.org/2926453002/ ) Reason for revert: temped_scoped_dir_cleaner is failing, see issue http://crbug.com/732835 Original issue's description: > Fix a race condition in ~RegistryHashStoreContentsWin > > Enabling mojo-ification of Tracked Preference code highlighted a race > condition in integration tests: two instances of > RegistryHashStoreContentsWin for the same profile can destructed at the > same time on different threads, causing one of the registry operations > initiated by the destructor to fail. > > BUG=727282 > > Review-Url: https://codereview.chromium.org/2926453002 > Cr-Commit-Position: refs/heads/master@{#479020} > Committed: https://chromium.googlesource.com/chromium/src/+/7c8c48226fd78ad01858284bd2ee91bed27b513c TBR=gab@chromium.org,proberge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=727282 Review-Url: https://codereview.chromium.org/2937633003 Cr-Commit-Position: refs/heads/master@{#479037} Committed: https://chromium.googlesource.com/chromium/src/+/a3a1cec34a434ca7c0ef4ac4f52b9bd8540873af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -200 lines) Patch
M services/preferences/tracked/registry_hash_store_contents_win.h View 2 chunks +8 lines, -19 lines 0 comments Download
M services/preferences/tracked/registry_hash_store_contents_win.cc View 3 chunks +18 lines, -31 lines 0 comments Download
M services/preferences/tracked/registry_hash_store_contents_win_unittest.cc View 3 chunks +1 line, -93 lines 0 comments Download
D services/preferences/tracked/temp_scoped_dir_cleaner.h View 1 chunk +0 lines, -18 lines 0 comments Download
M services/preferences/tracked/tracked_persistent_pref_store_factory.cc View 4 chunks +15 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
DaleCurtis
Created Revert of Fix a race condition in ~RegistryHashStoreContentsWin
3 years, 6 months ago (2017-06-13 16:18:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937633003/1
3 years, 6 months ago (2017-06-13 16:18:49 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 16:19:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3a1cec34a434ca7c0ef4ac4f52b...

Powered by Google App Engine
This is Rietveld 408576698