Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 2937553005: Revert of [Battery] Allow usage from SecureContext or top-level browsing context only. (Closed)

Created:
3 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 6 months ago
Reviewers:
riju_, timvolodine, foolip
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, haraken, Rick Byers
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Battery] Allow usage from SecureContext or top-level browsing context only. (patchset #6 id:160001 of https://codereview.chromium.org/2880763002/ ) Reason for revert: This CL should have gotten a API OWNER lgtm with an Intent to Ship. If the change is accepted by the API OWNERS, we should re-land this. Original issue's description: > [Battery] Allow usage from SecureContext or top-level browsing context only. > > Make the Battery Status API available only within a secure context that is > also a top-level browsing context. This disallows the use of the API within > framed content, as well as from any content that is not a secure context. > > Details: https://github.com/w3c/battery/issues/10 > > WPT updated in https://github.com/w3c/web-platform-tests/pull/5871 > > BUG=661792 > > Review-Url: https://codereview.chromium.org/2880763002 > Cr-Commit-Position: refs/heads/master@{#476263} > Committed: https://chromium.googlesource.com/chromium/src/+/3543d97ca7a33fb8ad48261ad252428555747896 TBR=timvolodine@chromium.org,foolip@chromium.org,rijubrata.bhaumik@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=661792 Review-Url: https://codereview.chromium.org/2937553005 Cr-Commit-Position: refs/heads/master@{#479025} Committed: https://chromium.googlesource.com/chromium/src/+/f5f500ccbe3aa6f5bc50071c97f3fe6df3ef9efb

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
mlamouri (slow - plz ping)
Created Revert of [Battery] Allow usage from SecureContext or top-level browsing context only.
3 years, 6 months ago (2017-06-13 13:03:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937553005/1
3 years, 6 months ago (2017-06-13 13:03:28 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 15:22:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5f500ccbe3aa6f5bc50071c97f3...

Powered by Google App Engine
This is Rietveld 408576698