Create Mojo Struct for user information used in login/lock screen.

chrome/browser/chromeos/login/screens/user_selection_screen.h

Index: chrome/browser/chromeos/login/screens/user_selection_screen.h
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.h b/chrome/browser/chromeos/login/screens/user_selection_screen.h
index f9cc031c5c9e6bed40fd2ee470c25a40a51eba74..c750c52573973052f67266de1a6195a7eecee5d2 100644
--- a/chrome/browser/chromeos/login/screens/user_selection_screen.h
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.h
@@ -9,6 +9,7 @@
 #include <string>
 #include <vector>
 
+#include "ash/public/interfaces/lock_screen.mojom.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/timer/timer.h"
@@ -115,7 +116,23 @@ class UserSelectionScreen
   // Determines if user auth status requires online sign in.
   static bool ShouldForceOnlineSignIn(const user_manager::User* user);
 
+  // Fills |user_info| with information about |user|.
+  // TODO: Public sesssions exist in login screen, but not lock screen.
+  // We will need public session locales in the furture when we change login
+  // screen to view-based as well. See crbug.com/732452.
+  static void FillUserMojoStruct(user_manager::User* user,

[xiyuan, 2017/06/13 18:00:18]

nit: user_manager::User* -> const user_manager::User*

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

Done.

+                                 bool is_owner,
+                                 bool is_signin_to_add,
+                                 AuthType auth_type,
+                                 ash::mojom::LoginUserInfo& user_info);

[xiyuan, 2017/06/13 18:00:18]

nit: For function to initialize a struct, the prevailing style is either a
create function that returns the struct or an update function that takes
struct*.

That is,
  ash::mojom::LoginUserInfoPtr CreateUserMojoStruct(...);
or
  void FillUserMojoStruct(..., ash::mojom::LoginUserInfo* user_info);

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

Done.

+
+  static void FillMultiProfileUserPrefsInMojo(
+      user_manager::User* user,

[xiyuan, 2017/06/13 18:00:18]

nit: const user_manager::User*

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

This method is inlined in FillUserMojoStruct.

+      ash::mojom::LoginUserInfo& user_info,

[xiyuan, 2017/06/13 18:00:18]

nit: ash::mojom::LoginUserInfo& -> ash::mojom::LoginUserInfo*

And make it the last in args list as input args should precede output ones.

See
https://google.github.io/styleguide/cppguide.html#Function_Parameter_Ordering

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

Thanks for the information! 
This method is inlined in FillUserMojoStruct.

+      bool is_signin_to_add);
+
   std::unique_ptr<base::ListValue> PrepareUserList();
+  std::vector<ash::mojom::LoginUserInfoPtr> PrepareUserListToMojo();
 
  protected:
   UserBoardView* view_ = nullptr;