Create Mojo Struct for user information used in login/lock screen.

chrome/browser/chromeos/login/screens/user_selection_screen.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_USER_SELECTION_SCREEN_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_USER_SELECTION_SCREEN_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
+#include "ash/public/interfaces/lock_screen.mojom.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/timer/timer.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/login/screens/base_screen.h"
 #include "chrome/browser/chromeos/login/signin/token_handle_util.h"
 #include "chrome/browser/chromeos/login/ui/login_display.h"
 #include "components/proximity_auth/screenlock_bridge.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "components/user_manager/user.h"
@@ skipping 86 matching lines @@
                                  base::DictionaryValue* user_dict);
 
   // Fills |user_dict| with |user| multi-profile related preferences.
   static void FillMultiProfileUserPrefs(user_manager::User* user,
                                         base::DictionaryValue* user_dict,
                                         bool is_signin_to_add);
 
   // Determines if user auth status requires online sign in.
   static bool ShouldForceOnlineSignIn(const user_manager::User* user);
 
+  // Fills |user_info| with information about |user|.
+  // TODO: Public sesssions exist in login screen, but not lock screen.
+  // We will need public session locales in the furture when we change login
+  // screen to view-based as well. See crbug.com/732452.
+  static void FillUserMojoStruct(user_manager::User* user,

[xiyuan, 2017/06/13 18:00:18]

nit: user_manager::User* -> const user_manager::User*

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

Done.

+                                 bool is_owner,
+                                 bool is_signin_to_add,
+                                 AuthType auth_type,
+                                 ash::mojom::LoginUserInfo& user_info);

[xiyuan, 2017/06/13 18:00:18]

nit: For function to initialize a struct, the prevailing style is either a
create function that returns the struct or an update function that takes
struct*.

That is,
  ash::mojom::LoginUserInfoPtr CreateUserMojoStruct(...);
or
  void FillUserMojoStruct(..., ash::mojom::LoginUserInfo* user_info);

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

Done.

+
+  static void FillMultiProfileUserPrefsInMojo(
+      user_manager::User* user,

[xiyuan, 2017/06/13 18:00:18]

nit: const user_manager::User*

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

This method is inlined in FillUserMojoStruct.

+      ash::mojom::LoginUserInfo& user_info,

[xiyuan, 2017/06/13 18:00:18]

nit: ash::mojom::LoginUserInfo& -> ash::mojom::LoginUserInfo*

And make it the last in args list as input args should precede output ones.

See
https://google.github.io/styleguide/cppguide.html#Function_Parameter_Ordering

[xiaoyinh(OOO Sep 11-29), 2017/06/13 22:21:31]

Thanks for the information! 
This method is inlined in FillUserMojoStruct.

+      bool is_signin_to_add);
+
   std::unique_ptr<base::ListValue> PrepareUserList();
+  std::vector<ash::mojom::LoginUserInfoPtr> PrepareUserListToMojo();
 
  protected:
   UserBoardView* view_ = nullptr;
 
   // Map from public session account IDs to recommended locales set by policy.
   std::map<AccountId, std::vector<std::string>>
       public_session_recommended_locales_;
 
  private:
   class DircryptoMigrationChecker;
@@ skipping 30 matching lines @@
   user_manager::UserList users_to_send_;
 
   base::WeakPtrFactory<UserSelectionScreen> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(UserSelectionScreen);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SCREENS_USER_SELECTION_SCREEN_H_