[Extensions] Use gin::DataObjectBuilder in NotificationsNativeHandler

[Extensions] Use gin::DataObjectBuilder in NotificationsNativeHandler

Right now, NotificationsNativeHandler::GetNotificationImageSizes()
builds a DictionaryValue and then passes that to V8ValueConverter to
convert it to a v8::Object. Instead, we can use gin::DataObjectBuilder,
which should be faster (since it's much more lightweight, and doesn't
require setting up a DictionaryValue we won't use - not to mention
fewer heap allocations).

BUG=None

Review-Url: https://codereview.chromium.org/2937543002
Cr-Commit-Position: refs/heads/master@{#478778}
Committed: https://chromium.googlesource.com/chromium/src/+/3280f87f0133f9b0c4f61c1b955fa290eb86ecbf

[Devlin, 2017-06-12 17:41:14]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 17:41:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 18:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 18:20:35]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-12 19:01:05]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 19:01:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-12 19:56:02]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org

[Devlin, 2017-06-12 19:56:02]

jbroman@, mind taking a look?

lazyboy@, FYI.

[jbroman, 2017-06-12 20:33:30]

lgtm

[Devlin, 2017-06-12 20:35:10]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-12 20:35:13]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-06-12 20:35:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 21:50:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497299713343120,
"parent_rev": "876bb220728d85b1c8a8fe93a0a95bafcf448cd6", "commit_rev":
"3280f87f0133f9b0c4f61c1b955fa290eb86ecbf"}

[commit-bot: I haz the power, 2017-06-12 21:50:32]

Description was changed from

==========
[Extensions] Use gin::DataObjectBuilder in NotificationsNativeHandler

Right now, NotificationsNativeHandler::GetNotificationImageSizes()
builds a DictionaryValue and then passes that to V8ValueConverter to
convert it to a v8::Object. Instead, we can use gin::DataObjectBuilder,
which should be faster (since it's much more lightweight, and doesn't
require setting up a DictionaryValue we won't use - not to mention
fewer heap allocations).

BUG=None
==========

to

==========
[Extensions] Use gin::DataObjectBuilder in NotificationsNativeHandler

Right now, NotificationsNativeHandler::GetNotificationImageSizes()
builds a DictionaryValue and then passes that to V8ValueConverter to
convert it to a v8::Object. Instead, we can use gin::DataObjectBuilder,
which should be faster (since it's much more lightweight, and doesn't
require setting up a DictionaryValue we won't use - not to mention
fewer heap allocations).

BUG=None

Review-Url: https://codereview.chromium.org/2937543002
Cr-Commit-Position: refs/heads/master@{#478778}
Committed:
https://chromium.googlesource.com/chromium/src/+/3280f87f0133f9b0c4f61c1b955f...
==========

[commit-bot: I haz the power, 2017-06-12 21:50:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3280f87f0133f9b0c4f61c1b955f...