Chromium Code Reviews
Description[Extensions] Use gin::DataObjectBuilder in NotificationsNativeHandler
Right now, NotificationsNativeHandler::GetNotificationImageSizes()
builds a DictionaryValue and then passes that to V8ValueConverter to
convert it to a v8::Object. Instead, we can use gin::DataObjectBuilder,
which should be faster (since it's much more lightweight, and doesn't
require setting up a DictionaryValue we won't use - not to mention
fewer heap allocations).
BUG=None
Review-Url: https://codereview.chromium.org/2937543002
Cr-Commit-Position: refs/heads/master@{#478778}
Committed: https://chromium.googlesource.com/chromium/src/+/3280f87f0133f9b0c4f61c1b955fa290eb86ecbf
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 15 (11 generated)
|