Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2937503004: [ObjC ARC] Converts ios/web:ios_web_public_unittests to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, liaoyuke+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, baxley+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/web:ios_web_public_unittests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2937503004 Cr-Commit-Position: refs/heads/master@{#479295} Committed: https://chromium.googlesource.com/chromium/src/+/06957aa81b3f6a4a314bb05fb1b3f476dd3c015a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/origin_util_unittest.mm View 3 chunks +8 lines, -15 lines 0 comments Download
M ios/web/public/serializable_user_data_manager_unittest.mm View 2 chunks +9 lines, -6 lines 0 comments Download
M ios/web/public/test/crw_mock_web_state_delegate.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/user_agent_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_state/page_viewport_state_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-13 19:21:30 UTC) #6
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-06-14 01:04:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937503004/1
3 years, 6 months ago (2017-06-14 05:26:16 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 05:31:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06957aa81b3f6a4a314bb05fb1b3...

Powered by Google App Engine
This is Rietveld 408576698