Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2937503003: Reapply "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binar… (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binaries." Add missing config to run_vm_tests. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/9ab39ae09987c16a6d5488162c4d7400dd47e04c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -95 lines) Patch
M runtime/BUILD.gn View 6 chunks +47 lines, -21 lines 0 comments Download
M runtime/bin/BUILD.gn View 4 chunks +68 lines, -50 lines 1 comment Download
M runtime/bin/vmservice/loader.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/BUILD.gn View 9 chunks +36 lines, -0 lines 0 comments Download
M utils/application_snapshot.gni View 3 chunks +16 lines, -7 lines 0 comments Download
M utils/dartanalyzer/BUILD.gn View 3 chunks +15 lines, -4 lines 0 comments Download
M utils/generate_patch_sdk.gni View 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
https://codereview.chromium.org/2937503003/diff/1/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2937503003/diff/1/runtime/bin/BUILD.gn#newcode855 runtime/bin/BUILD.gn:855: "..:dart_use_target_arch_config", Here
3 years, 6 months ago (2017-06-12 23:59:57 UTC) #2
zra
lgtm
3 years, 6 months ago (2017-06-13 00:33:46 UTC) #3
rmacnak
3 years, 6 months ago (2017-06-13 15:49:06 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9ab39ae09987c16a6d5488162c4d7400dd47e04c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698