Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: utils/dartanalyzer/BUILD.gn

Issue 2937503003: Reapply "[fuchsia] Prepare for setting the Dart target architecture appropriately in the host binar… (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/dartanalyzer/BUILD.gn
diff --git a/utils/dartanalyzer/BUILD.gn b/utils/dartanalyzer/BUILD.gn
index 47467e92dd0a765d241948b0006639ba1f9d47d0..eadca2feff486ea21a1fc0c932aaaaccd02665c2 100644
--- a/utils/dartanalyzer/BUILD.gn
+++ b/utils/dartanalyzer/BUILD.gn
@@ -14,7 +14,10 @@ group("dartanalyzer") {
}
analyzer_files = exec_script("../../tools/list_dart_files.py",
- [ "absolute", rebase_path("../../pkg/analyzer") ],
+ [
+ "absolute",
+ rebase_path("../../pkg/analyzer"),
+ ],
"list lines")
application_snapshot("generate_dartanalyzer_snapshot") {
@@ -25,13 +28,19 @@ application_snapshot("generate_dartanalyzer_snapshot") {
]
name = "dartanalyzer"
cli_files = exec_script("../../tools/list_dart_files.py",
- [ "absolute", rebase_path("../../pkg/analyzer_cli") ],
+ [
+ "absolute",
+ rebase_path("../../pkg/analyzer_cli"),
+ ],
"list lines")
inputs = cli_files + analyzer_files
}
sdk_lib_files = exec_script("../../tools/list_dart_files.py",
- [ "absolute", rebase_path("../../sdk/lib") ],
+ [
+ "absolute",
+ rebase_path("../../sdk/lib"),
+ ],
"list lines")
template("generate_summary") {
@@ -39,7 +48,9 @@ template("generate_summary") {
type = invoker.type
assert(type == "spec" || type == "strong")
compiled_action(target_name) {
- tool = "../../runtime/bin:dart"
+ # TODO(rmacnak): If Fuchsia adds a checked-in SDK, revert this to use
+ # the 'dart' binary.
+ tool = "../../runtime/bin:dart_bootstrap_host_arch"
inputs = sdk_lib_files + analyzer_files
output = "$root_gen_dir/$type.sum"

Powered by Google App Engine
This is Rietveld 408576698