Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2937433002: [heap] Register an idle embedder garbage collection when starting incremental marking through reach… (Closed)

Created:
3 years, 6 months ago by Hannes Payer (out of office)
Modified:
3 years, 6 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Register an idle embedder garbage collection when starting incremental marking through reached marking limit. We need to schedule an idle garbage collection in the embedder to drive progress. The embedder is responsible to schedule the request or ignore it. BUG=chromium:728228 Review-Url: https://codereview.chromium.org/2937433002 Cr-Commit-Position: refs/heads/master@{#45866} Committed: https://chromium.googlesource.com/v8/v8/+/0cef7f7cf70453599887bbffd25b2e216cd63db3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/heap/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
ulan
lgtm
3 years, 6 months ago (2017-06-12 13:38:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937433002/1
3 years, 6 months ago (2017-06-12 13:45:20 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-12 15:58:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0cef7f7cf70453599887bbffd25b2e216cd...

Powered by Google App Engine
This is Rietveld 408576698