[arm64] Share constant pool entries in snapshot.

[arm64] Share constant pool entries in snapshot.

Port c15b3ffc773ef7b14655b59b1ce1437de903fdc0 and
6a99238b9004c8e14b7f86734ef071eac8198212 to arm64.

This reduces the snapshot size for arm64 by about 5.5%.

BUG=

Review-Url: https://codereview.chromium.org/2937413002
Cr-Commit-Position: refs/heads/master@{#46214}
Committed: https://chromium.googlesource.com/v8/v8/+/118958f5173bd0b5ad3211c0a6467513dcb2f2c5

[georgia.kouveli, 2017-06-16 14:53:21]

georgia.kouveli@arm.com changed reviewers:
+ mstarzinger@chromium.org, mvstanton@chromium.org

[Michael Starzinger, 2017-06-20 10:00:43]

LGTM from my side, just nits.

https://codereview.chromium.org/2937413002/diff/1/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):

https://codereview.chromium.org/2937413002/diff/1/src/arm64/assembler-arm64.h...
src/arm64/assembler-arm64.h:833: typedef std::map<uint64_t, int>
shared_entry_map;
nit: s/shared_entry_map/SharedEntryMap/, to conform to V8 style.

[mvstanton, 2017-06-20 13:21:55]

Yep, lgtm!

[georgia.kouveli, 2017-06-20 15:16:58]

Also made another couple small changes. PTAL!

https://codereview.chromium.org/2937413002/diff/1/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):

https://codereview.chromium.org/2937413002/diff/1/src/arm64/assembler-arm64.h...
src/arm64/assembler-arm64.h:833: typedef std::map<uint64_t, int>
shared_entry_map;
On 2017/06/20 10:00:43, Michael Starzinger wrote:
> nit: s/shared_entry_map/SharedEntryMap/, to conform to V8 style.

Done.

[georgia.kouveli, 2017-06-26 10:03:58]

On 2017/06/20 15:16:58, georgia.kouveli wrote:
> Also made another couple small changes. PTAL!
> 
> https://codereview.chromium.org/2937413002/diff/1/src/arm64/assembler-arm64.h
> File src/arm64/assembler-arm64.h (right):
> 
>
https://codereview.chromium.org/2937413002/diff/1/src/arm64/assembler-arm64.h...
> src/arm64/assembler-arm64.h:833: typedef std::map<uint64_t, int>
> shared_entry_map;
> On 2017/06/20 10:00:43, Michael Starzinger wrote:
> > nit: s/shared_entry_map/SharedEntryMap/, to conform to V8 style.
> 
> Done.

Ping!

[Michael Starzinger, 2017-06-26 10:36:18]

Still LGTM. Sorry for delay, didn't realize you wanted me to take a second look.

[georgia.kouveli, 2017-06-26 10:36:40]

The CQ bit was checked by georgia.kouveli@arm.com

[georgia.kouveli, 2017-06-26 10:36:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2937413002/#ps20001
(title: "[arm64] Share constant pool entries in snapshot.")

[commit-bot: I haz the power, 2017-06-26 10:36:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 10:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 10:40:34]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[georgia.kouveli, 2017-06-26 12:59:59]

The CQ bit was checked by georgia.kouveli@arm.com

[commit-bot: I haz the power, 2017-06-26 13:00:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 13:03:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498481999537720,
"parent_rev": "c2217587705755f83a496f968c6efdbeafc78d82", "commit_rev":
"118958f5173bd0b5ad3211c0a6467513dcb2f2c5"}

[commit-bot: I haz the power, 2017-06-26 13:03:07]

Description was changed from

==========
[arm64] Share constant pool entries in snapshot.

Port c15b3ffc773ef7b14655b59b1ce1437de903fdc0 and
6a99238b9004c8e14b7f86734ef071eac8198212 to arm64.

This reduces the snapshot size for arm64 by about 5.5%.

BUG=
==========

to

==========
[arm64] Share constant pool entries in snapshot.

Port c15b3ffc773ef7b14655b59b1ce1437de903fdc0 and
6a99238b9004c8e14b7f86734ef071eac8198212 to arm64.

This reduces the snapshot size for arm64 by about 5.5%.

BUG=

Review-Url: https://codereview.chromium.org/2937413002
Cr-Commit-Position: refs/heads/master@{#46214}
Committed:
https://chromium.googlesource.com/v8/v8/+/118958f5173bd0b5ad3211c0a6467513dcb...
==========

[commit-bot: I haz the power, 2017-06-26 13:03:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/118958f5173bd0b5ad3211c0a6467513dcb...