Add missing methods to make compiling and linking of 32 bit integration_tests instrumented with LLV…

Add missing methods to make compiling and linking of 32 bit integration_tests instrumented with LLVM Asan possible.

BUG=

Code Review:https://codereview.chromium.org/2937353002

Review-Url: https://codereview.chromium.org/2937353002
Committed: https://github.com/google/syzygy/commit/cc60753e5dc038575b15d76b24b8ba26a839e898

[njanevsk, 2017-06-15 21:56:13]

Description was changed from

==========
Add missing methods to make compiling and linking of 32 bit integration_tests
instrumented with LLVM Asan possible.

BUG=
==========

to

==========
Add missing methods to make compiling and linking of 32 bit integration_tests
instrumented with LLVM Asan possible.

BUG=
==========

[njanevsk, 2017-06-15 21:56:13]

njanevsk@google.com changed reviewers:
+ etienneb@chromium.org, sebmarchand@chromium.org

[njanevsk, 2017-06-15 21:57:50]

Description was changed from

==========
Add missing methods to make compiling and linking of 32 bit integration_tests
instrumented with LLVM Asan possible.

BUG=
==========

to

==========
Add missing methods to make compiling and linking of 32 bit integration_tests
instrumented with LLVM Asan possible.

BUG=

Code Review:https://codereview.chromium.org/2937353002
==========

[njanevsk, 2017-06-15 22:03:05]

I moved all the methods needed to make 32 bit compilation and linking of hello
world and the integration_tests possible in this CL.

The methods for the 64 bit will be in a separate CL. The same goes for the
script for compiling and linking with llvm and the gyp file.

If you want to compile and link the integration_tests on your machine you can do
it using the following code:

cd syzygy\integration_tests

Below you need to use your path to the clang++ from llvm and also replace <path>
with your path to the syzygy/src. directory 
C:\src\llvm\out\build32\Release\bin\clang++ -c -fsanitize=address -mllvm
-asan-instrumentation-with-call-threshold=0 -mllvm -asan-stack=0 -DUNICODE
-D_UNICODE -DNOMINMAX -D_CRT_SECURE_NO_WARNINGS -I<path>
integration_tests_dll.cc asan_interceptors_tests.cc
"asan_page_protection_tests.cc" "bb_entry_tests.cc" "behavior_tests.cc"
"coverage_tests.cc" "deferred_free_tests.cc" "profile_tests.cc"

C:\src\llvm\out\build32\Release\bin\clang++ -shared  "integration_tests_dll.o"
"asan_interceptors_tests.o" "asan_page_protection_tests.o" "bb_entry_tests.o"
"behavior_tests.o" "coverage_tests.o" "deferred_free_tests.o" "profile_tests.o"
-o "<path>\out\Release\integration_tests_dll.dll"
-l"<path>\out\Release\export_dll.dll" -l"<path>\out\Release\syzyasan_rtl.dll"


All of this should work without any warnings or errors. If there are problems
let me know. Once you are done you can run the file integration_tests.exe. All
the tests will fail.

PTAL

[Sébastien Marchand, 2017-06-20 22:06:15]

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/gen/syste...
File syzygy/agent/asan/gen/system_interceptors.def (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/gen/syste...
syzygy/agent/asan/gen/system_interceptors.def:167:
__asan_handle_no_return=asan_handle_no_return
Nit: Add a blank line after this.

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
File syzygy/agent/asan/memory_interceptors.h (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
syzygy/agent/asan/memory_interceptors.h:194: // but are not implemented yet.
Some of this text could be moved to the previous line (80 chars per line)

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
syzygy/agent/asan/memory_interceptors.h:204: // The no-op string instruction
memory access checker.
These 2 functions are already declared, remove the duplication.

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
File syzygy/agent/asan/memory_interceptors_impl.h (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
syzygy/agent/asan/memory_interceptors_impl.h:114: // TODO (njanevsk): Implement
this function.
Add a BL between each function.

[njanevsk, 2017-06-21 14:39:30]

PTAL

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/gen/syste...
File syzygy/agent/asan/gen/system_interceptors.def (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/gen/syste...
syzygy/agent/asan/gen/system_interceptors.def:167:
__asan_handle_no_return=asan_handle_no_return
On 2017/06/20 22:06:14, Sébastien Marchand wrote:
> Nit: Add a blank line after this.

Done.

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
File syzygy/agent/asan/memory_interceptors.h (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
syzygy/agent/asan/memory_interceptors.h:194: // but are not implemented yet.
On 2017/06/20 22:06:14, Sébastien Marchand wrote:
> Some of this text could be moved to the previous line (80 chars per line)

Done.

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
syzygy/agent/asan/memory_interceptors.h:204: // The no-op string instruction
memory access checker.
On 2017/06/20 22:06:14, Sébastien Marchand wrote:
> These 2 functions are already declared, remove the duplication.

Done.

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
File syzygy/agent/asan/memory_interceptors_impl.h (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/memory_in...
syzygy/agent/asan/memory_interceptors_impl.h:114: // TODO (njanevsk): Implement
this function.
On 2017/06/20 22:06:14, Sébastien Marchand wrote:
> Add a BL between each function.

Done.

[Sébastien Marchand, 2017-06-21 14:55:41]

lgtm with one nit.

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/gen/syste...
File syzygy/agent/asan/gen/system_interceptors.def (right):

https://codereview.chromium.org/2937353002/diff/1/syzygy/agent/asan/gen/syste...
syzygy/agent/asan/gen/system_interceptors.def:167:
__asan_handle_no_return=asan_handle_no_return
On 2017/06/21 14:39:30, njanevsk wrote:
> On 2017/06/20 22:06:14, Sébastien Marchand wrote:
> > Nit: Add a blank line after this.
> 
> Done.

Nop, the BL is still missing.

[njanevsk, 2017-06-21 16:33:33]

The CQ bit was checked by njanevsk@google.com

[njanevsk, 2017-06-21 16:33:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
sebmarchand@chromium.org
Link to the patchset: https://codereview.chromium.org/2937353002/#ps40001
(title: "Add a blank line in the template file and regenerate the
system_interceptors.def")

[commit-bot: I haz the power, 2017-06-21 16:33:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 17:27:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498062813736290,
"parent_rev": "e2fe0d0e4156e8a320ddccc1cb79559329f54933", "commit_rev":
"cc60753e5dc038575b15d76b24b8ba26a839e898"}

[commit-bot: I haz the power, 2017-06-21 17:27:59]

Description was changed from

==========
Add missing methods to make compiling and linking of 32 bit integration_tests
instrumented with LLVM Asan possible.

BUG=

Code Review:https://codereview.chromium.org/2937353002
==========

to

==========
Add missing methods to make compiling and linking of 32 bit integration_tests
instrumented with LLVM Asan possible.

BUG=

Code Review:https://codereview.chromium.org/2937353002

Review-Url: https://codereview.chromium.org/2937353002
Committed:
https://github.com/google/syzygy/commit/cc60753e5dc038575b15d76b24b8ba26a839e898
==========

[commit-bot: I haz the power, 2017-06-21 17:28:01]

Committed patchset #3 (id:40001) as
https://github.com/google/syzygy/commit/cc60753e5dc038575b15d76b24b8ba26a839e898