Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2937333002: [Extensions Bindings] Update optional permissions tests (Closed)

Created:
3 years, 6 months ago by Devlin
Modified:
3 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Bindings] Update optional permissions tests Update the expected errors in optional permissions-related tests to accept the errors thrown by the native bindings system. JS: 'bookmarks' requires a different Feature that is not present. Native: 'bookmarks.getTree' is not available in this context. BUG=653596 TEST=browser_tests --gtest_filter=PermissionsApiTest.OptionalPermissionsGranted --native-crx-bindings=1 Review-Url: https://codereview.chromium.org/2937333002 Cr-Commit-Position: refs/heads/master@{#479918} Committed: https://chromium.googlesource.com/chromium/src/+/ab6c2f591d66ceca9ff7901de4f632a6e1a3260b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/test/data/extensions/api_test/permissions/optional/background.js View 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Devlin
lazyboy@, mind taking a look?
3 years, 6 months ago (2017-06-16 00:48:50 UTC) #6
lazyboy
lgtm
3 years, 6 months ago (2017-06-16 01:37:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937333002/1
3 years, 6 months ago (2017-06-16 01:38:58 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 02:02:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ab6c2f591d66ceca9ff7901de4f6...

Powered by Google App Engine
This is Rietveld 408576698