Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2937323003: Remove ability to disable new analysis driver (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -1887 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 25 chunks +101 lines, -626 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 12 chunks +36 lines, -132 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 4 chunks +74 lines, -144 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 chunk +2 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 4 chunks +7 lines, -129 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 8 chunks +29 lines, -119 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 4 chunks +10 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 2 chunks +0 lines, -11 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 5 chunks +2 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/server/http_server.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/status/diagnostics.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 8 chunks +0 lines, -328 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 16 chunks +66 lines, -190 lines 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 4 chunks +43 lines, -49 lines 0 comments Download
M pkg/analysis_server/test/domain_execution_test.dart View 2 chunks +82 lines, -112 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
There's still a lot of code that can be removed or cleaned up, but I ...
3 years, 6 months ago (2017-06-15 21:36:17 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-06-16 15:56:43 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-06-19 15:13:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e0216fef7f34d58e7fd2d4cad98cdcfa336f4142 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698