Remove ability to disable new analysis driver

pkg/analysis_server/test/domain_analysis_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:analysis_server/protocol/protocol.dart';
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/constants.dart';
@@ skipping 49 matching lines @@
         serverPlugin,
         new AnalysisServerOptions(),
         new DartSdkManager('/', false),
         InstrumentationService.NULL_SERVICE);
     handler = new AnalysisDomainHandler(server);
   });
 
   group('updateContent', testUpdateContent);
 
   group('AnalysisDomainHandler', () {
-    group('getReachableSources', () {
-      test('valid sources', () async {
-        String fileA = '/project/a.dart';
-        String fileB = '/project/b.dart';
-        resourceProvider.newFile(fileA, 'import "b.dart";');
-        resourceProvider.newFile(fileB, '');
-
-        server.setAnalysisRoots('0', ['/project/'], [], {});
-
-        await server.onAnalysisComplete;
-
-        var request =
-            new AnalysisGetReachableSourcesParams(fileA).toRequest('0');
-        var response = handler.handleRequest(request);
-
-        Map json = response.toJson()[Response.RESULT];
-
-        // Sanity checks.
-        expect(json['sources'], hasLength(6));
-        expect(json['sources']['file:///project/a.dart'],
-            unorderedEquals(['dart:core', 'file:///project/b.dart']));
-        expect(json['sources']['file:///project/b.dart'], ['dart:core']);
-      });
-
-      test('invalid source', () async {
-        resourceProvider.newFile('/project/a.dart', 'import "b.dart";');
-        server.setAnalysisRoots('0', ['/project/'], [], {});
-
-        await server.onAnalysisComplete;
-
-        var request =
-            new AnalysisGetReachableSourcesParams('/does/not/exist.dart')
-                .toRequest('0');
-        var response = handler.handleRequest(request);
-        expect(response.error, isNotNull);
-        expect(response.error.code,
-            RequestErrorCode.GET_REACHABLE_SOURCES_INVALID_FILE);
-      });
-    });
+    // TODO(brianwilkerson) Re-enable these tests if we re-enable the
+    // analysis.getReachableSources request.
+//    group('getReachableSources', () {
+//      test('valid sources', () async {
+//        String fileA = '/project/a.dart';
+//        String fileB = '/project/b.dart';
+//        resourceProvider.newFile(fileA, 'import "b.dart";');
+//        resourceProvider.newFile(fileB, '');
+//
+//        server.setAnalysisRoots('0', ['/project/'], [], {});
+//
+//        await server.onAnalysisComplete;
+//
+//        var request =
+//            new AnalysisGetReachableSourcesParams(fileA).toRequest('0');
+//        var response = handler.handleRequest(request);
+//
+//        Map json = response.toJson()[Response.RESULT];
+//
+//        // Sanity checks.
+//        expect(json['sources'], hasLength(6));
+//        expect(json['sources']['file:///project/a.dart'],
+//            unorderedEquals(['dart:core', 'file:///project/b.dart']));
+//        expect(json['sources']['file:///project/b.dart'], ['dart:core']);
+//      });
+//
+//      test('invalid source', () async {
+//        resourceProvider.newFile('/project/a.dart', 'import "b.dart";');
+//        server.setAnalysisRoots('0', ['/project/'], [], {});
+//
+//        await server.onAnalysisComplete;
+//
+//        var request =
+//            new AnalysisGetReachableSourcesParams('/does/not/exist.dart')
+//                .toRequest('0');
+//        var response = handler.handleRequest(request);
+//        expect(response.error, isNotNull);
+//        expect(response.error.code,
+//            RequestErrorCode.GET_REACHABLE_SOURCES_INVALID_FILE);
+//      });
+//    });
 
     group('setAnalysisRoots', () {
       Response testSetAnalysisRoots(
           List<String> included, List<String> excluded) {
         Request request = new AnalysisSetAnalysisRootsParams(included, excluded)
             .toRequest('0');
         return handler.handleRequest(request);
       }
 
       group('excluded', () {
         test('excluded folder', () async {
           String fileA = '/project/aaa/a.dart';
           String fileB = '/project/bbb/b.dart';
           resourceProvider.newFile(fileA, '// a');
           resourceProvider.newFile(fileB, '// b');
           var response = testSetAnalysisRoots(['/project'], ['/project/bbb']);
-          var serverRef = server;
           expect(response, isResponseSuccess('0'));
-          // unit "a" is resolved eventually
-          // unit "b" is not resolved
-          await server.onAnalysisComplete;
-          expect(await serverRef.getResolvedCompilationUnit(fileA), isNotNull);
-          expect(await serverRef.getResolvedCompilationUnit(fileB), isNull);
         });
 
         test('not absolute', () async {
           var response = testSetAnalysisRoots([], ['foo/bar']);
           expect(
               response,
               isResponseFailure(
                   '0', RequestErrorCode.INVALID_FILE_PATH_FORMAT));
         });
 
@@ skipping 46 matching lines @@
           expect(
               response,
               isResponseFailure(
                   '0', RequestErrorCode.INVALID_FILE_PATH_FORMAT));
         });
       });
     });
 
     group('setPriorityFiles', () {
       test('invalid', () {
-        // TODO(paulberry): under the "eventual consistency" model this request
-        // should not be invalid.
         var request = new AnalysisSetPriorityFilesParams(['/project/lib.dart'])
             .toRequest('0');
         var response = handler.handleRequest(request);
-        expect(response, isResponseFailure('0'));
+        expect(response, isResponseSuccess('0'));
       });
 
       test('valid', () {
         resourceProvider.newFolder('/p1');
         resourceProvider.newFile('/p1/a.dart', 'library a;');
         resourceProvider.newFolder('/p2');
         resourceProvider.newFile('/p2/b.dart', 'library b;');
         resourceProvider.newFile('/p2/c.dart', 'library c;');
 
         var setRootsRequest =
@@ skipping 231 matching lines @@
     serverChannel = new MockServerChannel();
     resourceProvider = new MemoryResourceProvider();
     // Create an SDK in the mock file system.
     new MockSdk(resourceProvider: resourceProvider);
     server = new AnalysisServer(
         serverChannel,
         resourceProvider,
         new MockPackageMapProvider(),
         null,
         serverPlugin,
-        new AnalysisServerOptions()..enableNewAnalysisDriver = true,
+        new AnalysisServerOptions(),
         new DartSdkManager('/', false),
         InstrumentationService.NULL_SERVICE);
     handler = new AnalysisDomainHandler(server);
     // listen for notifications
     Stream<Notification> notificationStream =
         serverChannel.notificationController.stream;
     notificationStream.listen((Notification notification) {
       if (notification.event == ANALYSIS_ERRORS) {
         var decoded = new AnalysisErrorsParams.fromNotification(notification);
         filesErrors[decoded.file] = decoded.errors;
@@ skipping 347 matching lines @@
     plugin.AnalysisSetSubscriptionsParams params =
         pluginManager.analysisSetSubscriptionsParams;
     expect(params, isNotNull);
     Map<plugin.AnalysisService, List<String>> subscriptions =
         params.subscriptions;
     expect(subscriptions, hasLength(1));
     List<String> files = subscriptions[plugin.AnalysisService.HIGHLIGHTS];
     expect(files, [testFile]);
   }
 }