Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2937173002: Introduce FindLeftNonPseudoNodeInlineBox() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce FindLeftNonPseudoNodeInlineBox() This patch Introduces |FindLeftNonPseudoNodeInlineBox()| extracted from |EndPositionForLine()| to simplify it for improving code health. This patch is similar to the patch[1] which introduces |FindRightNonPseudoNodeInlineBox()|. [1] http://crrev.com/2938153002: Introduce FindRightNonPseudoNodeInlineBox() BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2937173002 Cr-Commit-Position: refs/heads/master@{#479655} Committed: https://chromium.googlesource.com/chromium/src/+/52a8a744798e4033ebf8fdc8e21cfe21fc1e89d0

Patch Set 1 : 2017-06-15T16:47:50 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp View 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-15 08:56:09 UTC) #5
yoichio
lgtm
3 years, 6 months ago (2017-06-15 09:31:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937173002/1
3 years, 6 months ago (2017-06-15 09:43:21 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 09:57:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/52a8a744798e4033ebf8fdc8e21c...

Powered by Google App Engine
This is Rietveld 408576698