[cast_channel] Create KeepAliveDelegate in CastSocket instead of in CastChannelOpenFunction

[cast_channel] Create KeepAliveDelegate in CastSocket instead of in CastChannelOpenFunction

Make CastSocket create and own KeepAliveDelegate and update browser tests.

To address code review comments: https://codereview.chromium.org/2925053005/diff/40001/components/cast_channel/cast_socket_service.cc#newcode182

BUG=687377
Review-Url: https://codereview.chromium.org/2937153002
Cr-Commit-Position: refs/heads/master@{#480209}
Committed: https://chromium.googlesource.com/chromium/src/+/ce0e628972d6f0473c760da5851add36e13ceb49

[zhaobin, 2017-06-15 01:42:50]

zhaobin@chromium.org changed reviewers:
+ imcheng@chromium.org, mfoltz@chromium.org

[mark a. foltz, 2017-06-15 20:36:53]

LGTM

Thanks!  Nice patch!!!

[zhaobin, 2017-06-16 00:39:16]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 00:39:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 00:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[zhaobin, 2017-06-16 03:29:22]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 03:29:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 03:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 03:41:42]

Dry run: This issue passed the CQ dry run.

[imcheng, 2017-06-16 21:04:58]

lgtm

[zhaobin, 2017-06-16 21:13:02]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-16 21:13:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 22:23:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-16 22:23:10]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-06-16 22:48:08]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-06-16 22:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org,
imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2937153002/#ps20001
(title: "rebase with master")

[commit-bot: I haz the power, 2017-06-16 22:48:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 22:53:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497653288732040,
"parent_rev": "7c3d1e278d0aef75ca64cb5778ff3b923acb626b", "commit_rev":
"437770dffea16fd1d4bd80b6e29d71523e672536"}

[commit-bot: I haz the power, 2017-06-16 22:53:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497653288732040,
"parent_rev": "2bb854b6ebcbf7cf4e44bbd3d0326e05836b40fb", "commit_rev":
"6c2bacd8d0d7ddf4d768d33508d2ea98e1ae8f34"}

[commit-bot: I haz the power, 2017-06-16 22:53:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497653288732040,
"parent_rev": "283c7d1a34ff2873104332f277f812590b886e86", "commit_rev":
"ce0e628972d6f0473c760da5851add36e13ceb49"}

[commit-bot: I haz the power, 2017-06-16 22:53:50]

Description was changed from

==========
[cast_channel] Create KeepAliveDelegate in CastSocket instead of in
CastChannelOpenFunction

Make CastSocket create and own KeepAliveDelegate and update browser tests.

To address code review comments:
https://codereview.chromium.org/2925053005/diff/40001/components/cast_channel...

BUG=687377
==========

to

==========
[cast_channel] Create KeepAliveDelegate in CastSocket instead of in
CastChannelOpenFunction

Make CastSocket create and own KeepAliveDelegate and update browser tests.

To address code review comments:
https://codereview.chromium.org/2925053005/diff/40001/components/cast_channel...

BUG=687377

Review-Url: https://codereview.chromium.org/2937153002
Cr-Commit-Position: refs/heads/master@{#480209}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce0e628972d6f0473c760da5851a...
==========

[commit-bot: I haz the power, 2017-06-16 22:53:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce0e628972d6f0473c760da5851a...