Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2937123004: [milo] remove unused code. (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
Ryan Tseng, estaab, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[milo] remove unused code. Just browsing through the code, and it looks like these bits are out of date / unused. We can always revive them through the Power of Git, if needed :) R=estaab@chromium.org, hinoka@chromium.org BUG= Review-Url: https://codereview.chromium.org/2937123004 Committed: https://github.com/luci/luci-go/commit/248e4ae3627fb6a14aec7cf556cb41cdb6aafc29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -361 lines) Patch
D milo/appengine/backend/git/collector.go View 1 chunk +0 lines, -126 lines 0 comments Download
M milo/appengine/console/console.go View 2 chunks +2 lines, -1 line 0 comments Download
D milo/appengine/model/doc.go View 1 chunk +0 lines, -6 lines 0 comments Download
D milo/appengine/model/revision.go View 1 chunk +0 lines, -69 lines 0 comments Download
D milo/appengine/model/settings.go View 1 chunk +0 lines, -13 lines 0 comments Download
D milo/client/cmd/backfill/README.md View 1 chunk +0 lines, -22 lines 0 comments Download
D milo/client/cmd/backfill/main.go View 1 chunk +0 lines, -124 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
iannucci
3 years, 6 months ago (2017-06-16 03:27:15 UTC) #1
Ryan Tseng
lgtm
3 years, 6 months ago (2017-06-16 18:08:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937123004/1
3 years, 6 months ago (2017-06-16 18:37:53 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 18:43:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/248e4ae3627fb6a14aec7cf556cb41cdb6aafc29

Powered by Google App Engine
This is Rietveld 408576698