Fix QuicHttpStream reporting negative sent bytes.

Fix QuicHttpStream reporting negative sent bytes.

It was treating error codes as number of header bytes sent.
This may have affected metrics slightly, not sure if it had any
had any web-visible or devtools-visible effects.

BUG=731819
Review-Url: https://codereview.chromium.org/2937113002
Cr-Commit-Position: refs/heads/master@{#479749}
Committed: https://chromium.googlesource.com/chromium/src/+/ffff364f06b3fa261dcf249ded47675c2d0d48a3

[mmenke, 2017-06-14 21:17:08]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 21:17:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-14 21:18:30]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-14 21:18:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-14 21:20:40]

mmenke@chromium.org changed reviewers:
+ rch@chromium.org

[mmenke, 2017-06-14 21:20:41]

https://codereview.chromium.org/2937113002/diff/20001/net/quic/chromium/quic_...
File net/quic/chromium/quic_http_stream_test.cc (right):

https://codereview.chromium.org/2937113002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_http_stream_test.cc:1534: EXPECT_LE(0,
stream_->GetTotalSentBytes());
This could be EQ, since the writes are synchronous, but I'm paranoid.

https://codereview.chromium.org/2937113002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_http_stream_test.cc:1534: EXPECT_LE(0,
stream_->GetTotalSentBytes());
Speaking of which...We don't have any async version of these tests.  Should we?

[commit-bot: I haz the power, 2017-06-14 23:22:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 23:22:05]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mmenke, 2017-06-15 15:33:32]

mmenke@chromium.org changed reviewers:
+ zhongyi@chromium.org
- rch@chromium.org

[mmenke, 2017-06-15 15:33:32]

Oops, looks like Ryan is out of town.

[+Zhongyi]:  PTAL

[Zhongyi Shi, 2017-06-15 17:32:20]

lgtm

Thanks for fixing this!

https://codereview.chromium.org/2937113002/diff/20001/net/quic/chromium/quic_...
File net/quic/chromium/quic_http_stream_test.cc (right):

https://codereview.chromium.org/2937113002/diff/20001/net/quic/chromium/quic_...
net/quic/chromium/quic_http_stream_test.cc:1534: EXPECT_LE(0,
stream_->GetTotalSentBytes());
On 2017/06/14 21:20:41, mmenke wrote:
> Speaking of which...We don't have any async version of these tests.  Should
we?

I think you're right. It might be covered implicitly in some other tests
already. But, yeah, no async version of these unit tests :(

[mmenke, 2017-06-15 17:33:16]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-15 17:33:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-15 17:37:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497547996267620,
"parent_rev": "fafb67d05a69c02a39a451f36a169bd76f10f453", "commit_rev":
"ffff364f06b3fa261dcf249ded47675c2d0d48a3"}

[commit-bot: I haz the power, 2017-06-15 17:37:41]

Description was changed from

==========
Fix QuicHttpStream reporting negative sent bytes.

It was treating error codes as number of header bytes sent.
This may have affected metrics slightly, not sure if it had any
had any web-visible ordevtools-visible effects.

BUG=731819
==========

to

==========
Fix QuicHttpStream reporting negative sent bytes.

It was treating error codes as number of header bytes sent.
This may have affected metrics slightly, not sure if it had any
had any web-visible ordevtools-visible effects.

BUG=731819

Review-Url: https://codereview.chromium.org/2937113002
Cr-Commit-Position: refs/heads/master@{#479749}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffff364f06b3fa261dcf249ded47...
==========

[commit-bot: I haz the power, 2017-06-15 17:37:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ffff364f06b3fa261dcf249ded47...

[mmenke, 2017-06-15 17:38:20]

Description was changed from

==========
Fix QuicHttpStream reporting negative sent bytes.

It was treating error codes as number of header bytes sent.
This may have affected metrics slightly, not sure if it had any
had any web-visible ordevtools-visible effects.

BUG=731819

Review-Url: https://codereview.chromium.org/2937113002
Cr-Commit-Position: refs/heads/master@{#479749}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffff364f06b3fa261dcf249ded47...
==========

to

==========
Fix QuicHttpStream reporting negative sent bytes.

It was treating error codes as number of header bytes sent.
This may have affected metrics slightly, not sure if it had any
had any web-visible or devtools-visible effects.

BUG=731819

Review-Url: https://codereview.chromium.org/2937113002
Cr-Commit-Position: refs/heads/master@{#479749}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffff364f06b3fa261dcf249ded47...
==========