Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of tes…

Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external plugin users to utilize. Reason discussed further in ticket: https://codereview.chromium.org/2934133002/

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/382ddb21c3efb0de5b887b155b595c3078715b5b

[maxkim, 2017-06-14 18:12:39]

Description was changed from

==========
Refactor: Removed ReplacementRange from test and ReplacementRange from src/.
Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external
plugin users to utilize.

BUG=
==========

to

==========
Refactor: Removed ReplacementRange from test and ReplacementRange from src/.
Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external
plugin users to utilize.

BUG=
==========

[maxkim, 2017-06-14 18:12:39]

maxkim@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com

[maxkim, 2017-06-14 18:13:16]

Description was changed from

==========
Refactor: Removed ReplacementRange from test and ReplacementRange from src/.
Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external
plugin users to utilize.

BUG=
==========

to

==========
Refactor: Removed ReplacementRange from test and ReplacementRange from src/.
Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external
plugin users to utilize. Reason discussed further in ticket:
https://codereview.chromium.org/2934133002/

BUG=
==========

[danrubel, 2017-06-14 21:40:07]

LGTM

[Brian Wilkerson, 2017-06-15 19:18:30]

lgtm

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
File pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart
(right):

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart:16: int
offset;
For public code we should probably make these fields final. We should also add
our standard "Clients can't extend, implement or mixin this class" disclaimer.
Both can happen in a separate CL.

Dan: Bigger question: Why did we define `ReplacementRange` rather than use
`SourceRange`? Perhaps CompletionTarget should have a `computeReplacementRange`
method that takes the request offset and returns a SourceRange.

[danrubel, 2017-06-15 19:39:46]

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
File pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart
(right):

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart:16: int
offset;
On 2017/06/15 19:18:30, Brian Wilkerson wrote:
> Dan: Bigger question: Why did we define `ReplacementRange` rather than use
> `SourceRange`? Perhaps CompletionTarget should have a
`computeReplacementRange`
> method that takes the request offset and returns a SourceRange.

I created it so that it would be obvious that this is not the current offset or
selection of the completion request, but rather the range of text that the IDE
should replace when completing a suggestion. That said, it probably makes sense
to refactor this into a SourceRange and utility method(s).

[maxkim, 2017-06-15 20:31:22]

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
File pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart
(right):

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart:16: int
offset;
On 2017/06/15 19:18:30, Brian Wilkerson wrote:
> For public code we should probably make these fields final. We should also add
> our standard "Clients can't extend, implement or mixin this class" disclaimer.
> Both can happen in a separate CL.
> 
> Dan: Bigger question: Why did we define `ReplacementRange` rather than use
> `SourceRange`? Perhaps CompletionTarget should have a
`computeReplacementRange`
> method that takes the request offset and returns a SourceRange.

Sure will submit in another CL.

[Brian Wilkerson, 2017-06-15 20:44:01]

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
File pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart
(right):

https://codereview.chromium.org/2937093002/diff/1/pkg/analyzer_plugin/lib/uti...
pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart:16: int
offset;
> Sure will submit in another CL.

If we remove ReplacementRange in favor of using SourceRange (which I think we
will), there's no need to clean this up.

[maxkim, 2017-06-16 18:19:08]

Description was changed from

==========
Refactor: Removed ReplacementRange from test and ReplacementRange from src/.
Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external
plugin users to utilize. Reason discussed further in ticket:
https://codereview.chromium.org/2934133002/

BUG=
==========

to

==========
Refactor: Removed ReplacementRange from test and ReplacementRange from src/.
Copied contents of test into lib/utilities and modified test path.
This is needed to expose ReplacementRange outside of test folder for external
plugin users to utilize. Reason discussed further in ticket:
https://codereview.chromium.org/2934133002/

BUG=
R=brianwilkerson@google.com, danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/382ddb21c3efb0de5b887b155b595c3078715b5b
==========

[maxkim, 2017-06-16 18:19:10]

Committed patchset #1 (id:1) manually as
382ddb21c3efb0de5b887b155b595c3078715b5b (presubmit successful).