Refactor: Removed ReplacementRange from test and ReplacementRange from src/. Copied contents of tes…

pkg/analyzer_plugin/lib/utilities/completion/replacement_range.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/standard_ast_factory.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/src/dart/ast/token.dart';
 import 'package:analyzer_plugin/src/utilities/completion/completion_target.dart';
 
 /**
  * Utility class for computing the code completion replacement range.
  */
 class ReplacementRange {
   // Copied from analysis_server/lib/src/services/completion/dart/completion_manager.dart
   int offset;

[Brian Wilkerson, 2017/06/15 19:18:30]

For public code we should probably make these fields final. We should also add
our standard "Clients can't extend, implement or mixin this class" disclaimer.
Both can happen in a separate CL.

Dan: Bigger question: Why did we define `ReplacementRange` rather than use
`SourceRange`? Perhaps CompletionTarget should have a `computeReplacementRange`
method that takes the request offset and returns a SourceRange.

[danrubel, 2017/06/15 19:39:45]

I created it so that it would be obvious that this is not the current offset or
selection of the completion request, but rather the range of text that the IDE
should replace when completing a suggestion. That said, it probably makes sense
to refactor this into a SourceRange and utility method(s).

[maxkim, 2017/06/15 20:31:22]

Sure will submit in another CL.

[Brian Wilkerson, 2017/06/15 20:44:01]

If we remove ReplacementRange in favor of using SourceRange (which I think we
will), there's no need to clean this up.

   int length;
 
   ReplacementRange(this.offset, this.length);
 
   factory ReplacementRange.compute(int requestOffset, CompletionTarget target) {
     bool isKeywordOrIdentifier(Token token) =>
         token.type.isKeyword || token.type == TokenType.IDENTIFIER;
 
     //TODO(danrubel) Ideally this needs to be pushed down into the contributors
     // but that implies that each suggestion can have a different replacement
@@ skipping 32 matching lines @@
           if (start <= requestOffset && requestOffset <= end) {
             // Replacement range for import URI
             return new ReplacementRange(start, end - start);
           }
         }
       }
     }
     return new ReplacementRange(requestOffset, 0);
   }
 }