Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2937083003: [NaCl SDK] Add comments in the implementation code of GoogleDriveFs (Closed)

Created:
3 years, 6 months ago by chanpatorikku
Modified:
3 years, 6 months ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Add comments in the implementation code of GoogleDriveFs PNaCl is on a path to deprecation, and GoogleDriveFs is compiled from PNaCl, so comments are added to the implementation code to inform that GoogleDriveFs is not going to be further developed. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk Review-Url: https://codereview.chromium.org/2937083003 Cr-Commit-Position: refs/heads/master@{#480250} Committed: https://chromium.googlesource.com/chromium/src/+/e401555dbefc3bd403bd2fc6d6e7db51c0869e80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M native_client_sdk/src/libraries/nacl_io/googledrivefs/googledrivefs.h View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/googledrivefs/googledrivefs.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/googledrivefs/googledrivefs_node.h View 1 chunk +4 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/googledrivefs/googledrivefs_node.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
chanpatorikku
ptal.
3 years, 6 months ago (2017-06-15 13:02:01 UTC) #6
Sam Clegg
lgtm
3 years, 6 months ago (2017-06-16 23:16:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2937083003/20001
3 years, 6 months ago (2017-06-16 23:17:13 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-17 00:48:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e401555dbefc3bd403bd2fc6d6e7...

Powered by Google App Engine
This is Rietveld 408576698