Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/css/PropertyRegistration.cpp

Issue 2937043002: CSS Properties & Values API: Compute initial values for transfrom-list type. (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/PropertyRegistration.cpp
diff --git a/third_party/WebKit/Source/core/css/PropertyRegistration.cpp b/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
index b7a75bb7e9de41aff60bacee4bdfcf89e1ddbd58..d50270fa503698c9f8b68fb57a1624f8147a0250 100644
--- a/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
+++ b/third_party/WebKit/Source/core/css/PropertyRegistration.cpp
@@ -63,6 +63,15 @@ static bool ComputationallyIndependent(const CSSValue& value) {
return true;
}
+ if (value.IsFunctionValue()) {
meade_UTC10 2017/06/28 07:20:03 CSSFunctionValue inherits from CSSValueList, and f
Hwanseung Lee 2017/06/28 23:37:31 it is working well without these lines. i removed
+ for (const CSSValue* inner_value : ToCSSFunctionValue(value)) {
+ if (!ComputationallyIndependent(*inner_value)) {
+ return false;
+ }
+ }
+ return true;
+ }
+
if (value.IsPrimitiveValue()) {
const CSSPrimitiveValue& primitive_value = ToCSSPrimitiveValue(value);
if (!primitive_value.IsLength() &&
@@ -80,8 +89,7 @@ static bool ComputationallyIndependent(const CSSValue& value) {
return true;
}
- // TODO(timloh): Images and transform-function values can also contain
- // lengths.
+ // TODO(timloh): Images values can also contain lengths.
return true;
}

Powered by Google App Engine
This is Rietveld 408576698