Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password (Closed)
Patch Set: Changes addressed to vabr@ comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 6bab16977bc1d0a34eb78ee23223b23ae32c131b..ae90dfcaa421a462bff2c40fc7b3db7381c7d4f6 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -153,11 +153,26 @@ class PasswordFormManager : public FormFetcher::Consumer {
void LogSubmitPassed();
void LogSubmitFailed();
+ // Called when generated password is accepted or changed by user.
+ void PresaveGeneratedPassword(const autofill::PasswordForm& form);
+
+ // Called when user removed a generated password.
+ void PasswordNoLongerGenerated();
+
// These functions are used to determine if this form has had it's password
// auto generated by the browser.
bool has_generated_password() const { return has_generated_password_; }
void SetHasGeneratedPassword(bool generated_password);
+ // These functions are used to determine if this form has generated password
+ // changed by user.
+ bool generated_password_changed() const {
+ return generated_password_changed_;
+ }
+ void set_generated_password_changed(bool generated_password_changed) {
+ generated_password_changed_ = generated_password_changed;
+ }
+
bool is_manual_generation() { return is_manual_generation_; }
void set_is_manual_generation(bool is_manual_generation) {
is_manual_generation_ = is_manual_generation;
@@ -458,6 +473,9 @@ class PasswordFormManager : public FormFetcher::Consumer {
// Whether this form has an auto generated password.
bool has_generated_password_;
+ // Whether this form has a generated password changed by user.
+ bool generated_password_changed_;
+
// Whether password generation was manually triggered.
bool is_manual_generation_;

Powered by Google App Engine
This is Rietveld 408576698