components/password_manager/content/browser/content_password_manager_driver.cc - Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2937033002: [Password Generation] Send a boolean flag of whether user changed generated password (Closed)

Patch Set: Changes addressed to vabr@ comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/proto/server.proto ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc

index 3a847908681bdfbd34ecf955403cc35d274593cb..88fa1f0fb5292684d2195003a01439b9bf51a9ef 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver.cc

@@ -272,8 +272,7 @@ void ContentPasswordManagerDriver::PasswordNoLongerGenerated(

password_form.origin,

BadMessageReason::CPMD_BAD_ORIGIN_PASSWORD_NO_LONGER_GENERATED))

return;

- GetPasswordManager()->SetHasGeneratedPasswordForForm(this, password_form,

- false);

+ GetPasswordManager()->OnPasswordNoLongerGenerated(password_form);

}

void ContentPasswordManagerDriver::SaveGenerationFieldDetectedByClassifier(