Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2936963003:
Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). (Closed)
|
Created:
3 years, 6 months ago by yoichio Modified:
3 years, 6 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse SelectionPaintRange::Iterator in LayoutSelection::ClearSelection().
ClearSelection() only uses LayoutObjects that just SelectionPaintRange
iterates.
BUG=708453
TEST=No change in behavior
Review-Url: https://codereview.chromium.org/2936963003
Cr-Commit-Position: refs/heads/master@{#479304}
Committed: https://chromium.googlesource.com/chromium/src/+/2d27e28015730c2d6f814ff24cc0ae811303eee3
Patch Set 1 #
Total comments: 2
Patch Set 2 : split #Messages
Total messages: 23 (16 generated)
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Description was changed from ========== Use range for-loop in LayoutSelection::ClearSelection(). That makes CollectSelectedMap simple too. BUG=708453 ========== to ========== Use range for-loop in LayoutSelection::ClearSelection(). That makes CollectSelectedMap simple too. BUG=708453 TEST=No change in behavior ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use range for-loop in LayoutSelection::ClearSelection(). That makes CollectSelectedMap simple too. BUG=708453 TEST=No change in behavior ========== to ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). That alao makes CollectSelectedMap simple. BUG=708453 TEST=No change in behavior ==========
yoichio@chromium.org changed reviewers: + yosin@chromium.org
Description was changed from ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). That alao makes CollectSelectedMap simple. BUG=708453 TEST=No change in behavior ========== to ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). That also makes CollectSelectedMap simple. BUG=708453 TEST=No change in behavior ==========
Description was changed from ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). That also makes CollectSelectedMap simple. BUG=708453 TEST=No change in behavior ========== to ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). That also makes CollectSelectedMap simple. BUG=708453 TEST=No change in behavior ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
It is better to split this patch into: 1. Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). 2. That also makes CollectSelectedMap simple. These changes are isolated. https://codereview.chromium.org/2936963003/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right): https://codereview.chromium.org/2936963003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/LayoutSelection.cpp:240: SelectedMap old_selected_map = CollectSelectedMap(old_range); nit: s/SelectedMap/const SelectedMap&/ https://codereview.chromium.org/2936963003/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/LayoutSelection.cpp:253: SelectedMap new_selected_map = CollectSelectedMap(new_range); nit: s/SelectedMap/const SelectedMap&/
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). That also makes CollectSelectedMap simple. BUG=708453 TEST=No change in behavior ========== to ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). ClearSelection() only uses LayoutObjects that just SelectionPaintRange iterates. BUG=708453 TEST=No change in behavior ==========
On 2017/06/14 04:01:16, yosin_UTC9 wrote: > It is better to split this patch into: > 1. Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). > 2. That also makes CollectSelectedMap simple. > > These changes are isolated. Done.
The CQ bit was unchecked by yosin@chromium.org
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497416324046110,
"parent_rev": "600950a6cab835f6a2932ead72cb0c0a34782fa5", "commit_rev":
"2d27e28015730c2d6f814ff24cc0ae811303eee3"}
Message was sent while issue was closed.
Description was changed from ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). ClearSelection() only uses LayoutObjects that just SelectionPaintRange iterates. BUG=708453 TEST=No change in behavior ========== to ========== Use SelectionPaintRange::Iterator in LayoutSelection::ClearSelection(). ClearSelection() only uses LayoutObjects that just SelectionPaintRange iterates. BUG=708453 TEST=No change in behavior Review-Url: https://codereview.chromium.org/2936963003 Cr-Commit-Position: refs/heads/master@{#479304} Committed: https://chromium.googlesource.com/chromium/src/+/2d27e28015730c2d6f814ff24cc0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2d27e28015730c2d6f814ff24cc0... |
